From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate. Date: Thu, 08 Jun 2023 12:59:46 +0300 Message-ID: <83bkhq2s19.fsf@gnu.org> References: <834jnl4ub9.fsf@gnu.org> <831qio4z3d.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6520"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63913@debbugs.gnu.org To: Morgan Smith , Stefan Monnier , Jimmy Aguilar Mena Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 08 12:00:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7CRK-0001VK-FU for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Jun 2023 12:00:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7CR2-0007eB-Oq; Thu, 08 Jun 2023 06:00:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7CR1-0007e2-G6 for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 06:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7CR1-0006Mo-6e for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 06:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7CR0-0008Fi-5I for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 06:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Jun 2023 10:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63913 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63913-submit@debbugs.gnu.org id=B63913.168621839131679 (code B ref 63913); Thu, 08 Jun 2023 10:00:02 +0000 Original-Received: (at 63913) by debbugs.gnu.org; 8 Jun 2023 09:59:51 +0000 Original-Received: from localhost ([127.0.0.1]:55712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7CQp-0008Et-HX for submit@debbugs.gnu.org; Thu, 08 Jun 2023 05:59:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7CQm-0008Ed-3k for 63913@debbugs.gnu.org; Thu, 08 Jun 2023 05:59:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7CQe-0006JQ-P4; Thu, 08 Jun 2023 05:59:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/W+Z05h6KSK9KaMDE0x1eEp/anpeK13XHCVHQfXZH4w=; b=DUD1/WDAxTOs 02wB0Ha8XbeNUenb59mZt1nMHCZU+7wJATYpR3356sZRdvaHDW9IAf6F0CyVOeTIFA4HPhXJCDjMh E/wje38DR7SljscaMfh23GM/nI8GzcWvV+YPJhYiAXithmwzEwM2smoFqTgdMqXA7KKweyWylV0YI q8KlElIfQueszw8ZUcZxmiWNuV8TFXuUxs2vjHkzVe9aCQ7jo2ahD3EL3aU5TCD4kzsuYLQH+IEqs n/dIIQtjTiNoDPAukim5SK8eFhHvJ7punH6JlKaB60/KTcdPg4Kpu36pUMVcf0WmdPL5epJfl/6gC 9RRI4znSSYFtHYAbXEvOaw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7CQe-0001UX-9h; Thu, 08 Jun 2023 05:59:40 -0400 In-Reply-To: (message from Morgan Smith on Tue, 06 Jun 2023 15:08:26 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263118 Archived-At: > From: Morgan Smith > Cc: 63913@debbugs.gnu.org > Date: Tue, 06 Jun 2023 15:08:26 -0400 > > I'm running on commit 7ca1d782f5910d0c3978c6798a45c6854ec668c7 from the > master branch. > > I really hoping you can reproduce it with this: Apologies, it sounds like my original testing was faulty, as I can now reproduce your original recipe. What's more, it happens in Emacs 29 as well. I've added to the discussion folks that know more about this than I do. Stefan, Ergus: any comments to the issue or about the proposed patch? (I'm not sure we need to change the message when we do "ding", but that's a separate issue, I think.)