From: Eli Zaretskii <eliz@gnu.org>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: 64048@debbugs.gnu.org
Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled
Date: Tue, 13 Jun 2023 18:50:47 +0300 [thread overview]
Message-ID: <83bkhjweco.fsf@gnu.org> (raw)
In-Reply-To: <87a5x3sa7w.fsf@localhost> (message from Ihor Radchenko on Tue, 13 Jun 2023 14:33:39 +0000)
> From: Ihor Radchenko <yantar92@posteo.net>
> Date: Tue, 13 Jun 2023 14:33:39 +0000
>
> global-display-line-numbers-mode is defined as
>
> (define-globalized-minor-mode global-display-line-numbers-mode
> display-line-numbers-mode display-line-numbers--turn-on)
>
> Which unconditionally enables it when `display-line-numbers--turn-on'
> returns t.
>
> Wouldn't it be nicer to have something like
>
> (define-globalized-minor-mode global-display-line-numbers-mode
> display-line-numbers-mode display-line-numbers--turn-on
> :predicate #'display-line-numbers--turn-on)
>
> that will also define `display-line-numbers-modes' variable that
> controls where the global mode is enabled/disabled?
>
> Maybe it should even be the default in `define-globalized-minor-mode'
> when :predicate is not defined.
>
> WDYT?
I think it's too late for such changes, because it will definitely
break someone's setup.
next prev parent reply other threads:[~2023-06-13 15:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 14:33 bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Ihor Radchenko
2023-06-13 15:50 ` Eli Zaretskii [this message]
2023-06-13 16:09 ` Ihor Radchenko
2023-06-13 16:49 ` Eli Zaretskii
2023-06-13 17:21 ` Ihor Radchenko
2023-06-13 18:19 ` Eli Zaretskii
2023-06-13 19:36 ` Ihor Radchenko
2023-06-14 11:58 ` Eli Zaretskii
2023-06-14 12:48 ` Ihor Radchenko
2023-06-17 7:46 ` Eli Zaretskii
2023-06-17 18:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-17 18:58 ` Eli Zaretskii
2023-06-17 19:06 ` Ihor Radchenko
2023-06-17 19:04 ` Ihor Radchenko
2023-06-17 19:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bkhjweco.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64048@debbugs.gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).