From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63941: [PATCH] ; always CRLF before non-first boundary in multipart form Date: Mon, 19 Jun 2023 19:13:41 +0300 Message-ID: <83bkhb8m6i.fsf@gnu.org> References: <837csf4fp8.fsf@gnu.org> <83jzwe32pj.fsf@gnu.org> <83sfazzm8x.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23636"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63941@debbugs.gnu.org To: ozzloy Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 19 18:14:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBHWN-0005zF-2G for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jun 2023 18:14:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBHW0-0004Zf-Vd; Mon, 19 Jun 2023 12:14:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBHVz-0004ZW-OK for bug-gnu-emacs@gnu.org; Mon, 19 Jun 2023 12:14:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qBHVy-0001pg-Ip for bug-gnu-emacs@gnu.org; Mon, 19 Jun 2023 12:14:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qBHVy-00048L-F3 for bug-gnu-emacs@gnu.org; Mon, 19 Jun 2023 12:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jun 2023 16:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63941 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63941-submit@debbugs.gnu.org id=B63941.168719122715844 (code B ref 63941); Mon, 19 Jun 2023 16:14:02 +0000 Original-Received: (at 63941) by debbugs.gnu.org; 19 Jun 2023 16:13:47 +0000 Original-Received: from localhost ([127.0.0.1]:57097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBHVj-00047T-AZ for submit@debbugs.gnu.org; Mon, 19 Jun 2023 12:13:47 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBHVg-00047D-RT for 63941@debbugs.gnu.org; Mon, 19 Jun 2023 12:13:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBHVa-0001l8-R8; Mon, 19 Jun 2023 12:13:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NizzXucU2sncWxrvnxSGhocIde6t7wGvL1YU5tdTHEs=; b=a9ReRKrOiF2R osZlJHNi4bMSQsnn0rgvLekq+A51LFmcqljNFVqnNxYMhSglu7lEe9p5tRIpOvV8wvXWZ2GgV5ZTG YxYMFXphu8Ot+wq8XpxUIOeihOgBNz6mtVr+YIOS8coagVpn0ZFRFlUmMmNge5GSS9lzRz9/KGsRn 1myjoTGK85zTtH1M0c9+32GXwCYEnD9UGmf0rsA5pEknvA10sEH2HodoGl2/yvZgwyO1r7klo26uh iY9iK9M/jdWL63SvutqXU7QesQaJUSaSwhjRq1N4Z87fK6QEJtqj1GAY3vNNTW4J1thS3cQCzl7Tb +AusAdb1k1GE8fcaRjyANA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBHVZ-0001RO-5q; Mon, 19 Jun 2023 12:13:38 -0400 In-Reply-To: (message from ozzloy on Sun, 18 Jun 2023 16:23:23 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263690 Archived-At: > From: ozzloy > Date: Sun, 18 Jun 2023 16:23:23 -0700 > Cc: 63941@debbugs.gnu.org > > > who knows where it is used? > > As far as I can tell, it is only ever used by =(eww-submit ...)= from > =lisp/net/eww.el=. That's the only place it's used in all of emacs, > and every reference I can find on the web. > > I've tested the heck out of it now, and also used firefox, chromium, > and curl to generate http messages for comparison. > > Those tests of the different versions of > =mm-url-encode-multipart-form-data=, as well as the http messages > generated by firefox, chromium, and curl can be seen here > > https://git.sr.ht/~ozzloy/emacs-bug-63941/tree/53a7949a5db21c456c1da3b4add29343c3d02137/item/mm-url-tests.el > > > The patch I have attached to this email generates output that matches > firefox, chromium, and curl. It also includes a bunch of tests for > the included version of =mm-url-encode-multipart-form-data= > > If there's some change that would make the patch a better fit, let me > know. I'm happy to modify it. Thanks. I really need some Gnus/eww expert to look into this and review the patch.