From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Sun, 23 Jul 2023 20:56:17 +0300 Message-ID: <83bkg2tsu6.fsf@gnu.org> References: <1fd5e3ed-e1c3-5d6e-897f-1d5d55e379fa@gutov.dev> <87wmyupvlw.fsf@localhost> <5c4d9bea-3eb9-b262-138a-4ea0cb203436@gutov.dev> <87tttypp2e.fsf@localhost> <87r0p030w0.fsf@yahoo.com> <83sf9f6wm0.fsf@gnu.org> <83sf9eub9d.fsf@gnu.org> <2d844a34-857d-3d59-b897-73372baac480@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26706"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, sbaugh@janestreet.com, yantar92@posteo.net, 64735@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 23 19:56:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qNdJa-0006kU-FD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jul 2023 19:56:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNdJM-0001v0-4s; Sun, 23 Jul 2023 13:56:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNdJK-0001up-Fx for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 13:56:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNdJK-0007on-6c for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 13:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qNdJJ-0002fd-Qo for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 13:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jul 2023 17:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.169013495210243 (code B ref 64735); Sun, 23 Jul 2023 17:56:01 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 23 Jul 2023 17:55:52 +0000 Original-Received: from localhost ([127.0.0.1]:41212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNdJ7-0002f4-0V for submit@debbugs.gnu.org; Sun, 23 Jul 2023 13:55:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNdJ2-0002ed-F1 for 64735@debbugs.gnu.org; Sun, 23 Jul 2023 13:55:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNdIv-0007OL-Dw; Sun, 23 Jul 2023 13:55:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9loBuXdpOhwiQ4Q5Eh3mjURms7w4P6xpZYnIg0br91Y=; b=ip9d/HnpmSQR 6grqUFo7E72LVA8tWXeWNejoX9wEqdSpGWA7G5j+m67/6e12d/iB3vWKHtLO8MG26VjRvRjQkCFwy /rYMD7jB400jgJXHZAFDUG3EolwHhlIYOL70OphHAm7Nj0uG+I9cXSvgZhlct81G/WZrxnkXBheAT 7xH4Z+mlR2WJlh7JhVonTNPyYg8Ha1Itj9rLtWKwVSNDAD+MhtvkoJJUkQDBDIpS73VEhIAP/ZU6m Fzj2IsB3o25RkH3heSe316pkYtPZWZATr9ruj0+YEKLOY3s4ic3MyJ7YF5vsICK5IQzzpAWTB4o00 J/GqshgOra+0FNOuSPMnYQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNdIu-0006qx-S6; Sun, 23 Jul 2023 13:55:37 -0400 In-Reply-To: <2d844a34-857d-3d59-b897-73372baac480@gutov.dev> (message from Dmitry Gutov on Sun, 23 Jul 2023 20:46:19 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265919 Archived-At: > Date: Sun, 23 Jul 2023 20:46:19 +0300 > Cc: luangruo@yahoo.com, sbaugh@janestreet.com, yantar92@posteo.net, > 64735@debbugs.gnu.org > From: Dmitry Gutov > > On 23/07/2023 14:18, Eli Zaretskii wrote: > >> Date: Sun, 23 Jul 2023 13:46:30 +0300 > >> Cc:luangruo@yahoo.com,sbaugh@janestreet.com,yantar92@posteo.net, > >> 64735@debbugs.gnu.org > >> From: Dmitry Gutov > >> > >> On 23/07/2023 08:11, Eli Zaretskii wrote: > >>> Even better: compute completion-regexp-list so that IGNOREs are > >>> filtered by file-name-all-completions in the first place. > >> We don't have lookahead in Emacs regexps, so I'm not sure it's possible > >> to construct regexp that says "don't match entries A, B and C". > > Well, maybe just having a way of telling file-name-all-completions to > > negate the sense of completion-regexp-list would be enough to make > > that happen? > > Some way to do that is certainly possible (e.g. a new option and > corresponding code, maybe; maybe not), it's just that the person > implementing it should consider the performance of the resulting solution. I agree. However, if we are going to implement filtering of file names, I don't think it matters where in the pipeline to perform the filtering. The advantage of using completion-regexp-list is that the matching is done in C, so is probably at least a tad faster. > And, ideally, do all the relevant benchmarking when proposing the change. Of course. Although the benchmarks until now already show quite a variability.