From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61394: 30.0.50; [PATCH] Image-dired thumb name based on content Date: Fri, 28 Jul 2023 15:20:35 +0300 Message-ID: <83bkfwjkh8.fsf@gnu.org> References: <874jruy7xx.fsf@ledu-giraud.fr> <87ttztk0yw.fsf@tcd.ie> <87v8k9s6j9.fsf@ledu-giraud.fr> <83ilg8jzti.fsf@gnu.org> <87k00oo03r.fsf@ledu-giraud.fr> <838rh4jlsq.fsf@gnu.org> <87bklzol8n.fsf@ledu-giraud.fr> <877cwmo8ij.fsf@ledu-giraud.fr> <87y1oz54bn.fsf@ledu-giraud.fr> <87wn4dra0h.fsf@ledu-giraud.fr> <87bklhtwhd.fsf@ledu-giraud.fr> <871qgumqh7.fsf@ledu-giraud.fr> <83ila5n8co.fsf@gnu.org> <87fs59qx54.fsf@ledu-giraud.fr> <83wmyll9s5.fsf@gnu.org> <87bkfxcaa2.fsf@ledu-giraud.fr> <83wmykjzji.fsf@gnu.org> <877cqkcrds.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15336"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, stefankangas@gmail.com, 61394@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 28 14:50:54 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPMvm-0003n2-E0 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Jul 2023 14:50:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qPMRz-00010A-Iy; Fri, 28 Jul 2023 08:20:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPMRw-0000x4-Bf for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 08:20:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qPMRu-00045P-U2 for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 08:20:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qPMRu-00079M-5Z for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 08:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jul 2023 12:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61394 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61394-submit@debbugs.gnu.org id=B61394.169054679527468 (code B ref 61394); Fri, 28 Jul 2023 12:20:02 +0000 Original-Received: (at 61394) by debbugs.gnu.org; 28 Jul 2023 12:19:55 +0000 Original-Received: from localhost ([127.0.0.1]:43980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPMRm-00078y-JC for submit@debbugs.gnu.org; Fri, 28 Jul 2023 08:19:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPMRk-00078i-4Y for 61394@debbugs.gnu.org; Fri, 28 Jul 2023 08:19:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPMRc-00038S-QA; Fri, 28 Jul 2023 08:19:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZUvCkN9XVM4qVFPgf5HmEfuuPzeSsHhT0p8szeNQhqQ=; b=pVUaXF319oA9 kiepF7lF1etgKnRuQKeLlZebdwvswg/vZRulcJ3RIrn+OMMQDYXZ86lmsWldY8bxN+qHC3KqBFvBt liKgY/VAOzgsMkmmxb0Zwu8PkNElO8EFyWFmbVQu5YmHIjRCWTgqoB/FfS92rTFK5zHVDWioDbC6V Qx4aeLzb3bMCVpFXF4bMd9Lc/moJ0fSiX+LFMmJFkn0azMdnoKtkj11dg0GDn5PuImmoJitaR0vOB YTN7s4I7gDqYswbRNvJ5ZYPaO1ZAd+lr3M4cpbyg6DkwAOLi61VNlEevKEBMtEnwLLZyWgHzA52+k dKE1CHdRq75bYIi+IM/iXg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPMRa-00032d-HQ; Fri, 28 Jul 2023 08:19:44 -0400 In-Reply-To: <877cqkcrds.fsf@ledu-giraud.fr> (message from Manuel Giraud on Fri, 28 Jul 2023 11:33:19 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266272 Archived-At: > From: Manuel Giraud > Cc: stefankangas@gmail.com, contovob@tcd.ie, 61394@debbugs.gnu.org > Date: Fri, 28 Jul 2023 11:33:19 +0200 > > Eli Zaretskii writes: > > [...] > > > Thanks, the tests now pass, but I wonder about this part: > > > >> (should (equal (cdr (file-name-split > >> - (image-dired-thumb-name "/tmp/foo.jpg"))) > >> - '("tmp" ".image-dired" "foo.jpg.thumb.jpg"))) > >> + (image-dired-thumb-name abs-path))) > >> + (list "tmp" ".image-dired" hash-name))) > > > > Does this mean that thumbnail naming under 'per-directory' has > > changed, and it now uses the SHA-1 hash of the base-name? IOW, does > > this mean your changes for bug#61394 included incompatible changes in > > behavior? > > Yes I think it does. My patch for bug#61394 changes the previous > behaviour of 'image-dired-thumbnail-storage'. Now > 'image-dired-thumbnail-storage' defines where (ie. in which directory) > the thumbnails are stored and I introduce 'image-dired-thumb-naming' > which tells how thumbnail file ared named (ie. the file name part sans > directory). > > 'image-dired-thumb-naming' is meaning less if > 'image-dired-thumbnail-storage' is one of the "standard*" method because > those methods already define storage locations, file names and even > sizes. But for the "per-directory" method, I'm using > 'image-dired-thumb-naming'. As we are talking about thumbnail I did not > think it was a big deal but if it is I can prepare a patch, on top of > the one in place, and then 'image-dired-thumb-naming' will be used only > for the "image-dired" storage method. WDYT? I don't think I understand all the aspects of this, as I use neither image-dired nor the thumbnails. But it sounds like an incompatible change in behavior wrt what we have in Emacs 29? If so, how do we expect this to work for users who will have configured their Emacs for some particular storage type, and then upgrade to Emacs 30 when that is released? Will the existing thumbnails still work for them? Will Emacs 30 now start storing thumbnails under differently-formatted names, even though the user didn't change his/her configuration? In general, any incompatible change in behavior (if there is indeed such a change caused by this changeset) is undesirable. So I'd like first to discuss why there was a need for the behavior change in the first place. (I'm sorry that I didn't realize there was a change in behavior before installing the changeset. It seems we never discussed that aspect in the bug#61394 discussion thread.)