From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66390: `man' allows to inject arbitrary shell code Date: Mon, 09 Oct 2023 18:52:52 +0300 Message-ID: <83bkd7x06j.fsf@gnu.org> References: <83wmvyzir2.fsf@gnu.org> <585dcaf0-358e-4a9d-84d1-6fd9c2c8aec5@gmail.com> <83v8bizf9r.fsf@gnu.org> <1865abb8-16cd-4570-9a8a-87cf9430583d@gmail.com> <875y3iigua.fsf@gmx.de> <83o7hazap7.fsf@gnu.org> <87mswugyoq.fsf@gmx.de> <83jzryz6op.fsf@gnu.org> <87a5sugwcx.fsf@gmx.de> <83h6n2z3tr.fsf@gnu.org> <831qe5znrz.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17532"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66390@debbugs.gnu.org, michael.albinus@gmx.de To: Max Nikulin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 09 17:53:58 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qpsZx-0004ME-HB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Oct 2023 17:53:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qpsZk-00023x-11; Mon, 09 Oct 2023 11:53:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpsZi-00022w-05 for bug-gnu-emacs@gnu.org; Mon, 09 Oct 2023 11:53:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qpsZh-00087j-Oi for bug-gnu-emacs@gnu.org; Mon, 09 Oct 2023 11:53:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qpsa2-0001tD-2Z for bug-gnu-emacs@gnu.org; Mon, 09 Oct 2023 11:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Oct 2023 15:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66390 X-GNU-PR-Package: emacs Original-Received: via spool by 66390-submit@debbugs.gnu.org id=B66390.16968668177233 (code B ref 66390); Mon, 09 Oct 2023 15:54:02 +0000 Original-Received: (at 66390) by debbugs.gnu.org; 9 Oct 2023 15:53:37 +0000 Original-Received: from localhost ([127.0.0.1]:60720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpsZd-0001sb-1B for submit@debbugs.gnu.org; Mon, 09 Oct 2023 11:53:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpsZa-0001sO-MF for 66390@debbugs.gnu.org; Mon, 09 Oct 2023 11:53:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpsZ6-000855-NR; Mon, 09 Oct 2023 11:53:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=x5F1wgBMT0Wc6bkwjWGSDXv/Zf+XCKCdVhPR08r/rMI=; b=BHUWlLqqaSxW uhE2b9nOuLPX7gI1jFRaMbsm7tQ/drgepvAmIeO4QzORC6fj2sFO2aITMoyv9O5UREjfkrPBgO6L3 F0WTkdTOrXg1x+1G9K4/iMq7yZFVyZnwbeDnosp4DB4rY1c/l2iQDrGcEwxnFEup7Q2tyg3UiFGfa cbuGlWFhXioFhuJ5vkdKrBuDj36mz1k6EB9WbouRv+6kdZTPtEU6mlfZeKnJZKJfQKAeaXyJu1wOq 6+z0i+RIOGIqJCYjktkRH9cHevVk+oteK0LbZYul4YGb2EaRUU4H6lyxuA5D5zIX7nQmOwGwDtRP3 cbh+usPs91ZVYA0W7IzhdA==; In-Reply-To: (message from Max Nikulin on Mon, 9 Oct 2023 22:12:34 +0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272153 Archived-At: > Date: Mon, 9 Oct 2023 22:12:34 +0700 > Cc: michael.albinus@gmx.de, 66390@debbugs.gnu.org > From: Max Nikulin > > On 08/10/2023 12:28, Eli Zaretskii wrote: > >> Date: Sun, 8 Oct 2023 10:37:33 +0700 From: Max Nikulin > > > >> I had in mind using at least `shell-quote-argument'. > > That doesn't work with 'man', which has its own ideas about quoting, > > besides shell-related quoting. > > I see usage of `shell-quote-argument' for completion where shell is not > involved. During formatting there is parsing of references with some > regular expressions to get (X) section suffix, but I have not noticed > quoting. Certainly the code relies on spaces passed literally and > substituted into shell command directly. If there were page names with > spaces it would be a problem. > > I mean passing through `shell-quote-argument' each word returned by > `Man-translate-references' What will this do with a man page called [.1 ? > (defun Man-translate-cleanup (string) > "Strip leading, trailing and middle spaces." > ^^^^^^^^^^^^^ > > (Man-translate-cleanup " w") > " w" But (Man-translate-cleanup " ww") => "ww"