From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68294: [PATCH] Set the 'name' prop in 'define-advice' Date: Sat, 13 Jan 2024 11:44:19 +0200 Message-ID: <83bk9ph8jw.fsf@gnu.org> References: <87h6jqwdnn.fsf@stebalien.com> <83edetsloo.fsf@gnu.org> <8734v7x256.fsf@stebalien.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12357"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68294-done@debbugs.gnu.org, monnier@iro.umontreal.ca To: Steven Allen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 13 10:45:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOaZr-0002zC-EC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Jan 2024 10:45:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOaZd-0003Pf-FI; Sat, 13 Jan 2024 04:45:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOaZc-0003PG-6f for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2024 04:45:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOaZb-0002rq-TZ for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2024 04:45:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rOaZa-0008Oh-CP for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2024 04:45:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jan 2024 09:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 68294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 68294@debbugs.gnu.org, eliz@gnu.org, steven@stebalien.com Original-Received: via spool by 68294-done@debbugs.gnu.org id=D68294.170513908732186 (code D ref 68294); Sat, 13 Jan 2024 09:45:02 +0000 Original-Received: (at 68294-done) by debbugs.gnu.org; 13 Jan 2024 09:44:47 +0000 Original-Received: from localhost ([127.0.0.1]:38468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOaZK-0008N3-OU for submit@debbugs.gnu.org; Sat, 13 Jan 2024 04:44:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOaZI-0008Mp-2R for 68294-done@debbugs.gnu.org; Sat, 13 Jan 2024 04:44:45 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOaZE-0002Wa-1o; Sat, 13 Jan 2024 04:44:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DBgaHy0RTIgI8MHnDASRUL4om28s9AhsWntD9TA5YY8=; b=e5/2vhkSFuZ0 atpV1TR6io8Rj5vwGWnFK7bwrxi/0r1ykC4vsfx2v/unBStKPtsHwL6OOoPvkY6rcxbTxewzjTPXZ hKL5lNsH54LEuFM6kombyNgY+U3ijeWjLiY7NblTZDnAoYNDNO0ttdsb8dgfXD43h8s/VtmAUoCQU Okeiz7smCCjCEWWA/t2FINJP0NI2PLC70SwGp3/E5ygyHmfMU12l44uTYKarcKqA6F/9vBW5P8W/x yiYVn+1OIS9M0JaVZvvxrM5k/dvInRkU5X/fayL5tCgAVR3/KxGoTNXQ6iSoFOtUuYr6ZT2k+xeAz 7UqWoFs8/iiX32x3zCzApw==; In-Reply-To: <8734v7x256.fsf@stebalien.com> (message from Steven Allen on Mon, 08 Jan 2024 07:42:29 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278113 Archived-At: > From: Steven Allen > Cc: 68294@debbugs.gnu.org > Date: Mon, 08 Jan 2024 07:42:29 -0800 > > >> @defmac define-advice symbol (where lambda-list &optional name depth) &rest body > >> This macro defines a piece of advice and adds it to the function named > >> -@var{symbol}. The advice is an anonymous function if @var{name} is > >> -@code{nil} or a function named @code{symbol@@name}. See > >> -@code{advice-add} for explanation of other arguments. > >> +@var{symbol}. If @var{name} is non-nil, the advice is named > >> +@code{symbol@@name} and installed with the name @var{name}; otherwise, > > ^^^^^^^^^^^^^^^^^^^ > > This should be @code{@var{symbol}@@@var{name}}. > > Fixed. > > >> +** 'define-advice' now sets the new advice's 'name' property to NAME > >> +Named advice defined with 'define-advice' can now be remove with > > ^^^^^^ > > This should be "removed". > > Fixed. Thanks, installed on master, and closing the bug.