From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Sun, 23 Jul 2023 22:27:26 +0300 Message-ID: <83bd4246-ac41-90ec-1df3-02d0bd59ca44@gutov.dev> References: <1fd5e3ed-e1c3-5d6e-897f-1d5d55e379fa@gutov.dev> <87wmyupvlw.fsf@localhost> <5c4d9bea-3eb9-b262-138a-4ea0cb203436@gutov.dev> <87tttypp2e.fsf@localhost> <87r0p030w0.fsf@yahoo.com> <83sf9f6wm0.fsf@gnu.org> <83sf9eub9d.fsf@gnu.org> <2d844a34-857d-3d59-b897-73372baac480@gutov.dev> <83bkg2tsu6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26241"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: luangruo@yahoo.com, sbaugh@janestreet.com, yantar92@posteo.net, 64735@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 23 21:28:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qNekd-0006eh-K2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jul 2023 21:28:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNekO-0003s3-L5; Sun, 23 Jul 2023 15:28:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNekN-0003ra-8I for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 15:28:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNekN-0004mc-0m for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 15:28:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qNekM-0004wi-SS for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 15:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jul 2023 19:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.169014045718974 (code B ref 64735); Sun, 23 Jul 2023 19:28:02 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 23 Jul 2023 19:27:37 +0000 Original-Received: from localhost ([127.0.0.1]:41252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNejx-0004vy-9t for submit@debbugs.gnu.org; Sun, 23 Jul 2023 15:27:37 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:59089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNeju-0004vk-M1 for 64735@debbugs.gnu.org; Sun, 23 Jul 2023 15:27:35 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7BA745C0043; Sun, 23 Jul 2023 15:27:29 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 23 Jul 2023 15:27:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690140449; x=1690226849; bh=FbeRyXKYgT9IIX2gOp6H/B6wY2557U1eNIG Rf40ubkE=; b=Flt1Uu1OXcY0GgyALc/oLzFONhpD7wviJYWbAQZXsQtAVjOaxTg pU6ctedUSXdGuJ0GNko/RbHHwDhVDHz+XfYagKLgkfMvahef+yf2UImJY6W3TGsv 2+PyogyCu2DoP8GLZhj3A78rIg/Bcgvg9wEbzpCnL4y4k6V76eRdTIDubjxpvajq U5HYfH2jb9pHEXxxI8avniyeaDVbPNZdpFhDaG8Zjxmt4SZiIFa+eBfJJEaQKtR8 LTRipdYvs9fhmWE5EDOn248wAHyTxf33h8OyZcR52TAU6NxdOwnWbplUSmtL0NzA C1ZKuCb+Q5Fl6xtTk9dyUUkVTBrTJotacpw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690140449; x=1690226849; bh=FbeRyXKYgT9IIX2gOp6H/B6wY2557U1eNIG Rf40ubkE=; b=iPFKlGRxaGkkFiBCuahTf0kxvrLb8gyC7OvlpZ6cvYuDvyIQI3X Z76gkiumO0qXLZtyad78onQDBcxdqMcrhywUgMBOOQvaSeD/NESr67C4/WRUjxUb aX5KxX+GAOyw3oZ76DPMIivTpaqkxncgRvO7RZRbBWNIKI/GM9e8zYzvtDp4tLui X372XFfHEMI5Rbi2VwKRHo+3keq2oKQmmPisKNp8H41ddLZmTsNxtzfxtwtpdOst 6cijhKTDWo5MkSowIr9TtnBLGdxF0Q6mzyUDpNVlpKeiLL8+vUK+ZIl7K59vTbJk ifHSIkdMiUs3vhebvbKUSzHI+u3kKHiKR7A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrheeigddufeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 23 Jul 2023 15:27:27 -0400 (EDT) Content-Language: en-US In-Reply-To: <83bkg2tsu6.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265924 Archived-At: On 23/07/2023 20:56, Eli Zaretskii wrote: >> And, ideally, do all the relevant benchmarking when proposing the change. > Of course. Although the benchmarks until now already show quite a > variability. Speaking of your MS Windows results that are unflattering to 'find', it might be worth it to do a more varied comparison, to determine the OS-specific bottleneck. Off the top of my head, here are some possibilities: 1. 'find' itself is much slower there. There is room for improvement in the port. 2. The process output handling is worse. 3. Something particular to the project being used for the test. To look into the possibility #1, you can try running the same command in the terminal with the output to NUL and comparing the runtime to what's reported in the benchmark. I actually remember, from my time on MS Windows about 10 years ago, that some older ports of 'find' and/or 'grep' did have performance problems, but IIRC ezwinports contained the improved versions.