* bug#37016: 26.2; `pushnew' doc string (minor)
@ 2019-08-13 4:13 Drew Adams
2019-08-23 4:13 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Drew Adams @ 2019-08-13 4:13 UTC (permalink / raw)
To: 37016
1. Why does the first line of the doc string start with the calling
sequence (it's on the same line as the start of the doc string).
2. The first "sentence" is a bit misleading. It actually says that X is
inserted at the head of the list if it is not already at the head of
the list, which is not right. It should say something like "if not
already in the list", or "if not already a member of the list".
3. The doc string doesn't say what PLACE is, except that you can guess
from the description that it must be a list. To really understand
you need to consult the doc of `push'. The doc of `pushnew' could
say what is said in the doc of `push', without being longer than it
is now.
4. Even the doc string of `push' should say that a _list_ is stored in
PLACE.
http://clhs.lisp.se/Body/m_push.htm
In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32)
of 2019-04-13
Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749
Windowing system distributor `Microsoft Corp.', version 10.0.17763
Configured using:
`configure --without-dbus --host=x86_64-w64-mingw32
--without-compress-install 'CFLAGS=-O2 -static -g3''
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#37016: 26.2; `pushnew' doc string (minor)
2019-08-13 4:13 bug#37016: 26.2; `pushnew' doc string (minor) Drew Adams
@ 2019-08-23 4:13 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2019-08-23 4:13 UTC (permalink / raw)
To: Drew Adams; +Cc: 37016
Drew Adams <drew.adams@oracle.com> writes:
> 1. Why does the first line of the doc string start with the calling
> sequence (it's on the same line as the start of the doc string).
>
> 2. The first "sentence" is a bit misleading. It actually says that X is
> inserted at the head of the list if it is not already at the head of
> the list, which is not right. It should say something like "if not
> already in the list", or "if not already a member of the list".
>
> 3. The doc string doesn't say what PLACE is, except that you can guess
> from the description that it must be a list. To really understand
> you need to consult the doc of `push'. The doc of `pushnew' could
> say what is said in the doc of `push', without being longer than it
> is now.
>
> 4. Even the doc string of `push' should say that a _list_ is stored in
> PLACE.
I've now clarified the doc string as you suggest on the trunk.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-23 4:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-13 4:13 bug#37016: 26.2; `pushnew' doc string (minor) Drew Adams
2019-08-23 4:13 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).