From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#8439: [PATCH] ffap.el -- detect paths with spaces (v2) Date: Fri, 19 Oct 2012 11:49:25 +0200 Message-ID: <83a9vi23mi.fsf@gnu.org> References: <87pqoyaxu0.fsf@blue.sea.net> <874nlq9ah3.fsf@picasso.cante.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1350640254 7943 80.91.229.3 (19 Oct 2012 09:50:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Oct 2012 09:50:54 +0000 (UTC) Cc: hochberg@dmhsoftware.com, 8439@debbugs.gnu.org To: Jari Aalto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 19 11:51:01 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TP9EE-0008IA-Qo for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Oct 2012 11:50:54 +0200 Original-Received: from localhost ([::1]:47949 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TP9E7-00068N-Hz for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Oct 2012 05:50:47 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TP9Dy-00065C-4n for bug-gnu-emacs@gnu.org; Fri, 19 Oct 2012 05:50:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TP9Dt-0008O4-KQ for bug-gnu-emacs@gnu.org; Fri, 19 Oct 2012 05:50:38 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TP9Dt-0008Nz-H1 for bug-gnu-emacs@gnu.org; Fri, 19 Oct 2012 05:50:33 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TP9FJ-0007md-P9 for bug-gnu-emacs@gnu.org; Fri, 19 Oct 2012 05:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Oct 2012 09:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8439 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 8439-submit@debbugs.gnu.org id=B8439.135064028029870 (code B ref 8439); Fri, 19 Oct 2012 09:52:01 +0000 Original-Received: (at 8439) by debbugs.gnu.org; 19 Oct 2012 09:51:20 +0000 Original-Received: from localhost ([127.0.0.1]:51095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TP9Ee-0007lj-AI for submit@debbugs.gnu.org; Fri, 19 Oct 2012 05:51:20 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:63454) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TP9Ea-0007lS-UB for 8439@debbugs.gnu.org; Fri, 19 Oct 2012 05:51:18 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MC400J00WML9L00@a-mtaout21.012.net.il> for 8439@debbugs.gnu.org; Fri, 19 Oct 2012 11:49:37 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MC400J8KWMP7I40@a-mtaout21.012.net.il>; Fri, 19 Oct 2012 11:49:37 +0200 (IST) In-reply-to: <874nlq9ah3.fsf@picasso.cante.net> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65727 Archived-At: > From: Jari Aalto > Date: Fri, 19 Oct 2012 10:39:36 +0300 > Cc: Yigal Hochberg > > > With some more field testing, the following patch works better. > > 1. New variable ffap-paths-with-spaces controls if the behavior is in use. > By default it is set to "t" in Windows/Cygwin where spaces in paths > are encountered. GNU Coding Standards frown upon using "path" for anything except PATH-style lists of directories. Use "file name" or "leading directories" instead. > 2. The "path skipping" is based on finding longest distance: > > - from first "drive letter", "/" or "\" > - until last "/", "\" followed by last non-matching-char-not-usually-found-in-file-names What will this do to text such as the one below? C:\emacs\bin\prog1.exe on Windows or /usr/bin/prog1 on Unix. > 3. In Cygwin Emacs the paths are expected to be in "/cygdrive//" > format. What about Posix-standard /foo/bar/baz, which is the usual case on Cygwin?