From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18438: 24.4.50; assertion failed in bidi.c Date: Tue, 30 Sep 2014 19:27:37 +0300 Message-ID: <83a95hkr9i.fsf@gnu.org> References: <4745242cd3e424a6c4d5db0e8d3e33d0@amuri.net> <83h9zrlzc8.fsf@gnu.org> <54297FDB.6090606@cornell.edu> <837g0mmkf3.fsf@gnu.org> <6b19fab333f3d362ae61b30b299d7206@amuri.net> <83iok5ku74.fsf@gnu.org> <542AD5BC.2060408@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1412094507 26650 80.91.229.3 (30 Sep 2014 16:28:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 30 Sep 2014 16:28:27 +0000 (UTC) Cc: 18438@debbugs.gnu.org, aidalgol@amuri.net To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 30 18:28:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XZ0Hh-0001uS-MW for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Sep 2014 18:28:17 +0200 Original-Received: from localhost ([::1]:44355 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZ0Hh-00031Y-B3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Sep 2014 12:28:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZ0HZ-00031R-A4 for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 12:28:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZ0HT-00088U-7x for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 12:28:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZ0HT-00088N-4Y for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 12:28:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XZ0HS-0007eX-Gh for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2014 12:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Sep 2014 16:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 18438-submit@debbugs.gnu.org id=B18438.141209446829393 (code B ref 18438); Tue, 30 Sep 2014 16:28:02 +0000 Original-Received: (at 18438) by debbugs.gnu.org; 30 Sep 2014 16:27:48 +0000 Original-Received: from localhost ([127.0.0.1]:56514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XZ0HD-0007e0-U4 for submit@debbugs.gnu.org; Tue, 30 Sep 2014 12:27:48 -0400 Original-Received: from mtaout27.012.net.il ([80.179.55.183]:49989) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XZ0HB-0007dq-2F for 18438@debbugs.gnu.org; Tue, 30 Sep 2014 12:27:46 -0400 Original-Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NCQ00H002LDF500@mtaout27.012.net.il> for 18438@debbugs.gnu.org; Tue, 30 Sep 2014 19:22:18 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NCQ00GJD2T6QQ10@mtaout27.012.net.il>; Tue, 30 Sep 2014 19:22:18 +0300 (IDT) In-reply-to: <542AD5BC.2060408@cornell.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93924 Archived-At: > Date: Tue, 30 Sep 2014 12:09:32 -0400 > From: Ken Brown > CC: 18438@debbugs.gnu.org > > On 9/30/2014 11:24 AM, Eli Zaretskii wrote: > > OK, so far so good. How about the one below (which tries to reveal > > the face of the beast)? > > > > === modified file 'src/bidi.c' > > --- src/bidi.c 2014-04-06 15:56:01 +0000 > > +++ src/bidi.c 2014-09-30 15:21:28 +0000 > > @@ -326,7 +326,12 @@ bidi_get_type (int ch, bidi_dir_t overri > > static void > > bidi_check_type (bidi_type_t type) > > { > > - eassert (UNKNOWN_BT <= type && type <= NEUTRAL_ON); > > + if (!(suppress_checking || (UNKNOWN_BT <= type && type <= NEUTRAL_ON))) > > + { > > + fprintf (stderr, "\r\n%s:%d: bidi type %d is not in [%d..%d]\r\n", > > + __FILE__, __LINE__, type, UNKNOWN_BT, NEUTRAL_ON); > > + emacs_abort (); > > + } > > } > > > > /* Given a bidi TYPE of a character, return its category. */ > > Wouldn't it make sense for him to first see if your recent fix of the > "Current trunk aborts with MinGW" problem also fixes the present bug? Could be, yes. I actually thought about this possibility, but didn't mention it because I couldn't come up with a scenario where that bug could have triggered such strange problems, and only in bidi.c. But it does no harm to try applying that patch first, and only apply this one if that doesn't help. > We speculated previously that these strange assertion violations might > be a result of the w32_msg stuff not being thread safe. Yes, but you need memory allocation in the picture to have that, and I see no such allocation in the sequence of calls we saw in the backtraces. Still, "the proof of the pudding is in eating"... Thanks.