From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20978: 25.0.50; [PATCH 0/7] Emacs can return too fast when reading from any processes Date: Sat, 04 Jul 2015 15:52:44 +0300 Message-ID: <83a8vcxexv.fsf@gnu.org> References: <87zj3ckso6.fsf@iankelling.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1436014403 16957 80.91.229.3 (4 Jul 2015 12:53:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 4 Jul 2015 12:53:23 +0000 (UTC) Cc: 20978@debbugs.gnu.org To: Ian Kelling Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 04 14:53:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZBMwS-0001yC-Mr for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Jul 2015 14:53:12 +0200 Original-Received: from localhost ([::1]:44211 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBMwR-0007I2-QH for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Jul 2015 08:53:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBMwO-0007Ha-5U for bug-gnu-emacs@gnu.org; Sat, 04 Jul 2015 08:53:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZBMwJ-0003qK-3R for bug-gnu-emacs@gnu.org; Sat, 04 Jul 2015 08:53:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBMwI-0003qG-W6 for bug-gnu-emacs@gnu.org; Sat, 04 Jul 2015 08:53:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZBMwI-0002WZ-J1 for bug-gnu-emacs@gnu.org; Sat, 04 Jul 2015 08:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jul 2015 12:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20978 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20978-submit@debbugs.gnu.org id=B20978.14360143619666 (code B ref 20978); Sat, 04 Jul 2015 12:53:02 +0000 Original-Received: (at 20978) by debbugs.gnu.org; 4 Jul 2015 12:52:41 +0000 Original-Received: from localhost ([127.0.0.1]:39382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBMvw-0002Vp-Ew for submit@debbugs.gnu.org; Sat, 04 Jul 2015 08:52:40 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:36695) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBMvs-0002VX-Rq for 20978@debbugs.gnu.org; Sat, 04 Jul 2015 08:52:38 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NQY00J00RHYI500@a-mtaout23.012.net.il> for 20978@debbugs.gnu.org; Sat, 04 Jul 2015 15:52:30 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQY00JB6RRHHU10@a-mtaout23.012.net.il>; Sat, 04 Jul 2015 15:52:30 +0300 (IDT) In-reply-to: <87zj3ckso6.fsf@iankelling.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104690 Archived-At: > From: Ian Kelling > Date: Sat, 04 Jul 2015 05:34:33 -0700 > > About the patches: > > The first 4 are refactoring and not necessarily dependent on any others, > but independent patches would conflict and they make the code clearer so > I included them. I can separate any of them if needed. > > Patch 3 depends on the patch for debbugs:20976, which is a simple fix > and I expect no problem for it be applied first. Thanks. I don't know how others feel, but I personally would prefer that patches not be split between different messages, as that makes it harder to grasp and apply. Especially since some (most) of them belong to the same changeset. And refactoring should IMO be together with the actual changes. > I was careful to not squash unrelated changes as the function is rather > complicated and I could have saved a fair amount of time if there > weren't unrelated changes in the patch that introduced this bug. Unrelated is in the eyes of the beholder. We all have our different views on that. Thanks again for working on this. I will defer to Paul to provide the _real_ feedback ;-)