From: Eli Zaretskii <eliz@gnu.org>
To: Pip Cet <pipcet@gmail.com>
Cc: 21380@debbugs.gnu.org
Subject: bug#21380: 25.0.50; GTK-induced segfault when scheduling timer from window-configuration-change-hook
Date: Wed, 02 Sep 2015 18:08:00 +0300 [thread overview]
Message-ID: <83a8t4c10v.fsf@gnu.org> (raw)
In-Reply-To: <CAOqdjBd-LLOERx78ngF_n3fQM+O6zKbF3gbEme9t8Jwb7iT3RQ@mail.gmail.com>
> Date: Tue, 1 Sep 2015 20:48:18 +0000
> From: Pip Cet <pipcet@gmail.com>
> Cc: 21380@debbugs.gnu.org
>
> Alternatively, we could turn off atimers (by calling turn_on_atimers)
> while Fcopy_sequence runs.
>
>
> I think that would be a better solution. I've done a quick grep for the current
> atimers and at first glance they appear to be okay, but obviously that's no
> guarantee for the future. It might be worth thinking about
> block_input_and_atimers ().
>
> I think it's safe to assume that Lisp timers are only checked if atimers are
> enabled.
Those are two completely separate and independent features, so no,
it's not safe to make that assumption. Not sure why you need to
assume that, though.
> If it isn't, I think the best way forward is to write
> block_input_and_atimers () and lock atimers with a counter just like input is.
Not sure I follow you. Are you saying that just calling block_input
followed by turn_on_atimers is somehow not enough to prevent some Lisp
from changing Vtimer_list under our feet?
> --- a/src/fns.c
> +++ b/src/fns.c
> @@ -744,6 +744,9 @@ concat (ptrdiff_t nargs, Lisp_Object *args,
> /* Store this element into the result. */
> if (toindex < 0)
> {
> + if (NILP (tail))
> + break;
> +
Is this part still needed? If so, can you explain in what situation
it is needed?
Thanks.
next prev parent reply other threads:[~2015-09-02 15:08 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-30 12:51 bug#21380: 25.0.50; GTK-induced segfault when scheduling timer from window-configuration-change-hook Pip Cet
2015-08-30 15:01 ` Eli Zaretskii
2015-08-30 15:24 ` Pip Cet
2015-08-30 15:27 ` Pip Cet
2015-08-30 16:24 ` Pip Cet
2015-08-30 18:10 ` martin rudalics
2015-08-30 18:20 ` Pip Cet
2015-08-30 19:50 ` Eli Zaretskii
2015-08-30 18:59 ` Pip Cet
2015-08-31 9:20 ` martin rudalics
2015-08-30 16:39 ` Eli Zaretskii
2015-08-30 16:42 ` Pip Cet
2015-08-30 19:44 ` Eli Zaretskii
2015-08-30 20:56 ` Pip Cet
2015-08-30 21:13 ` Pip Cet
2015-08-31 14:31 ` Eli Zaretskii
2015-09-01 10:20 ` Pip Cet
2015-09-01 15:03 ` Eli Zaretskii
2015-09-01 15:22 ` Pip Cet
2015-09-01 16:01 ` Eli Zaretskii
2015-09-01 16:02 ` Pip Cet
2015-09-01 16:23 ` Eli Zaretskii
2015-09-02 7:02 ` martin rudalics
2015-09-02 14:32 ` Eli Zaretskii
2015-09-03 15:36 ` Stefan Monnier
2015-09-05 7:38 ` Eli Zaretskii
2015-09-05 15:18 ` Stefan Monnier
2015-09-05 15:27 ` Eli Zaretskii
2015-09-06 22:11 ` Stefan Monnier
2022-04-29 12:52 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-29 13:40 ` Eli Zaretskii
2022-04-29 13:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-29 15:02 ` Pip Cet
2015-09-05 16:59 ` Pip Cet
2015-09-06 22:22 ` Stefan Monnier
2015-09-08 15:55 ` Pip Cet
2015-09-01 15:14 ` Pip Cet
2015-09-01 16:04 ` Eli Zaretskii
2015-09-01 16:56 ` Pip Cet
2015-09-01 17:19 ` Eli Zaretskii
2015-09-01 20:48 ` Pip Cet
2015-09-02 15:08 ` Eli Zaretskii [this message]
2015-09-02 16:09 ` Pip Cet
2015-09-02 19:13 ` Eli Zaretskii
2015-09-02 22:08 ` Pip Cet
2020-09-07 17:07 ` Lars Ingebrigtsen
2020-09-07 17:47 ` Pip Cet
2020-09-07 19:09 ` Eli Zaretskii
2020-09-08 9:57 ` Lars Ingebrigtsen
2022-04-29 12:14 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a8t4c10v.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=21380@debbugs.gnu.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).