From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Tue, 03 Nov 2015 17:49:17 +0200 Message-ID: <83a8qvw0aq.fsf@gnu.org> References: <87h9l6627a.fsf@mail.linkov.net> <20151031235651.GE1853@acm.fritz.box> <87bnbddzpk.fsf@mail.linkov.net> <20151102092853.GA11804@acm.fritz.box> <20151102123512.GB11804@acm.fritz.box> <20151102154445.GD11804@acm.fritz.box> <87h9l46l7o.fsf@mail.linkov.net> <20151103123116.GD2258@acm.fritz.box> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1446565822 2796 80.91.229.3 (3 Nov 2015 15:50:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Nov 2015 15:50:22 +0000 (UTC) Cc: 17453@debbugs.gnu.org, bruce.connor.am@gmail.com, juri@linkov.net To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 03 16:50:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ztdqc-0002Hy-LW for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2015 16:50:10 +0100 Original-Received: from localhost ([::1]:49497 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztdqc-000733-2k for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2015 10:50:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtdqX-00071l-QQ for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 10:50:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtdqU-0004xv-K3 for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 10:50:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtdqU-0004xk-GZ for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 10:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZtdqU-0002SA-BF for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 10:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Nov 2015 15:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17453 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17453-submit@debbugs.gnu.org id=B17453.14465657869400 (code B ref 17453); Tue, 03 Nov 2015 15:50:02 +0000 Original-Received: (at 17453) by debbugs.gnu.org; 3 Nov 2015 15:49:46 +0000 Original-Received: from localhost ([127.0.0.1]:51630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZtdqD-0002RY-FI for submit@debbugs.gnu.org; Tue, 03 Nov 2015 10:49:45 -0500 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:59575) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZtdqB-0002RP-IR for 17453@debbugs.gnu.org; Tue, 03 Nov 2015 10:49:44 -0500 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NX800O00WXLLY00@mtaout29.012.net.il> for 17453@debbugs.gnu.org; Tue, 03 Nov 2015 17:48:22 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NX800KA3X8MCM60@mtaout29.012.net.il>; Tue, 03 Nov 2015 17:48:22 +0200 (IST) In-reply-to: <20151103123116.GD2258@acm.fritz.box> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108354 Archived-At: PLEASE let's keep emacs-devel out of this?? > Date: Tue, 3 Nov 2015 12:31:16 +0000 > From: Alan Mackenzie > Cc: 17453@debbugs.gnu.org, Artur Malabarba , > emacs-devel > > This is complicated. Ideally, the Follow Mode windows should be > synchronised in FM's post-command-hook, not isearch's. It is not > isearch's job to realign windows. follow-post-command-hook both realigns > windows and choses an appropriate window to put point in. We should let > it. Once again, if some code in Isearch calls the same function that is used in follow-post-command-hook, the above is not an issue. Moreover, saving some calls to the hook will make Emacs more responsive. (Right now, using Follow mode is a pain due to the hook: even a simple C-f is annoyingly slow.) > What I'm proposing is to schedule the timer always, and do the checks > (for whether we need to start a new lazy highlight loop) in the function > that the timer triggers. The advantage is that when the timer triggers, > redisplay will already have taken place[*] I don't think you can count on that: if there's a ripe timer, it will be processed before redisplay. I think.