unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: 22757@debbugs.gnu.org
Subject: bug#22757: 25.1.50; `face-at-point` and `faces--attribute-at-point` -- add argument WINDOW-OR-BUFFER
Date: Sun, 21 Feb 2016 22:54:07 +0200	[thread overview]
Message-ID: <83a8mtn5sg.fsf@gnu.org> (raw)
In-Reply-To: <m2egc67xci.wl%esq@lawlist.com> (message from Keith David Bershatsky on Sun, 21 Feb 2016 10:05:33 -0800)

> Date: Sun, 21 Feb 2016 10:05:33 -0800
> From: Keith David Bershatsky <esq@lawlist.com>
> 
> As a feature request, please consider adding an additional argument to `face-at-point` and `faces--attribute-at-point` to support WINDOW-OR-BUFFER with `get-char-property`; and, add that to the sections of code in said functions containing `get-char-property`.  The doc-strings would need to be updated to explain the difference.  The default would be BUFFER.
> 
> It is sometimes useful to be able to obtain a face of an overlay that is associated with a particular window -- e.g., an active region that may be different in each window.  The current functions do not have the ability to test for that occurrence because the third argument of `get-char-property` is always `nil`.

Why can't you call get-char-property directly?  face-at-point is
nothing more than a thin wrapper around get-char-property, and most of
the wrapper code is about stuff you don't care about AFAIU from your
description.

Is there something I'm missing?

Thanks.





  reply	other threads:[~2016-02-21 20:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-21 18:05 bug#22757: 25.1.50; `face-at-point` and `faces--attribute-at-point` -- add argument WINDOW-OR-BUFFER Keith David Bershatsky
2016-02-21 20:54 ` Eli Zaretskii [this message]
2016-02-21 21:23 ` Keith David Bershatsky
2016-02-22 15:58   ` Eli Zaretskii
2016-02-21 21:23 ` Keith David Bershatsky
2016-02-22 18:15 ` bug#22757: Reply to correspondence dated February 22, 2016 Keith David Bershatsky
2016-02-22 19:25   ` Eli Zaretskii
2022-02-03 20:51     ` bug#22757: 25.1.50; `face-at-point` and `faces--attribute-at-point` -- add argument WINDOW-OR-BUFFER Lars Ingebrigtsen
2016-02-22 18:17 ` Keith David Bershatsky
2016-02-22 19:46 ` Keith David Bershatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a8mtn5sg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=22757@debbugs.gnu.org \
    --cc=esq@lawlist.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).