From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix Date: Sat, 27 Aug 2016 11:57:47 +0300 Message-ID: <83a8fyd1x0.fsf@gnu.org> References: <83d1kud3m1.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1472288299 25172 195.159.176.226 (27 Aug 2016 08:58:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 27 Aug 2016 08:58:19 +0000 (UTC) Cc: 24317@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 27 10:58:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdZRO-000676-OF for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Aug 2016 10:58:14 +0200 Original-Received: from localhost ([::1]:35197 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdZRM-0005vI-1d for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Aug 2016 04:58:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdZRG-0005pe-9c for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 04:58:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdZRB-00023z-V2 for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 04:58:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdZRB-00023u-SI for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 04:58:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bdZRB-0008AU-MI for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 04:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Aug 2016 08:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24317 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24317-submit@debbugs.gnu.org id=B24317.147228825631366 (code B ref 24317); Sat, 27 Aug 2016 08:58:01 +0000 Original-Received: (at 24317) by debbugs.gnu.org; 27 Aug 2016 08:57:36 +0000 Original-Received: from localhost ([127.0.0.1]:41837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdZQm-00089q-LF for submit@debbugs.gnu.org; Sat, 27 Aug 2016 04:57:36 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdZQk-00089c-Sb for 24317@debbugs.gnu.org; Sat, 27 Aug 2016 04:57:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdZQc-00022u-6G for 24317@debbugs.gnu.org; Sat, 27 Aug 2016 04:57:29 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdZQc-00022p-2w; Sat, 27 Aug 2016 04:57:26 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1440 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bdZQa-00048m-A5; Sat, 27 Aug 2016 04:57:24 -0400 In-reply-to: (message from Tino Calancha on Sat, 27 Aug 2016 17:53:49 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122714 Archived-At: > From: Tino Calancha > Date: Sat, 27 Aug 2016 17:53:49 +0900 (JST) > cc: Tino Calancha , 24317@debbugs.gnu.org > > > I understand why we need to fix a typo in the regexp (which the log > > entry doesn't even mention, btw), but what's the rationale for making > > it a defvar? > I made a defvar because it was used in 2 functions: only one show the > typo. In that case, why not make a function that does the string-match as well, in which case you won't need a variable, because it will appear in a single place, and will also have the test localized to a single function? Thanks.