From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation Date: Sat, 03 Sep 2016 13:14:24 +0300 Message-ID: <83a8fpe1dr.fsf@gnu.org> References: <87ha4jgw53.fsf@secretsauce.net> <87si0ion1c.fsf@gnus.org> <87k2et8hr4.fsf@secretsauce.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1472897734 21957 195.159.176.226 (3 Sep 2016 10:15:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 3 Sep 2016 10:15:34 +0000 (UTC) Cc: larsi@gnus.org, 17544@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 03 12:15:27 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bg7yr-0003pJ-UM for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Sep 2016 12:15:22 +0200 Original-Received: from localhost ([::1]:45539 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bg7yk-00042W-GM for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Sep 2016 06:15:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bg7yc-0003yA-7Q for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 06:15:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bg7yY-0007b7-BK for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 06:15:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bg7yY-0007b3-8v for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 06:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bg7yY-0005az-3X for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 06:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Sep 2016 10:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17544-submit@debbugs.gnu.org id=B17544.147289767921466 (code B ref 17544); Sat, 03 Sep 2016 10:15:02 +0000 Original-Received: (at 17544) by debbugs.gnu.org; 3 Sep 2016 10:14:39 +0000 Original-Received: from localhost ([127.0.0.1]:48262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bg7y8-0005a5-DO for submit@debbugs.gnu.org; Sat, 03 Sep 2016 06:14:39 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bg7y3-0005Zp-Uc for 17544@debbugs.gnu.org; Sat, 03 Sep 2016 06:14:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bg7xt-0007QB-Sy for 17544@debbugs.gnu.org; Sat, 03 Sep 2016 06:14:26 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bg7xt-0007Pi-Pa; Sat, 03 Sep 2016 06:14:21 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3393 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bg7xr-00026l-Se; Sat, 03 Sep 2016 06:14:20 -0400 In-reply-to: <87k2et8hr4.fsf@secretsauce.net> (message from Dima Kogan on Sat, 03 Sep 2016 02:17:19 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122882 Archived-At: > From: Dima Kogan > Date: Sat, 03 Sep 2016 02:17:19 -0700 > Cc: 17544@debbugs.gnu.org > > Lars Ingebrigtsen writes: > > > I think this makes sense, and the patch looks good to me. Does it > > still apply to the Emacs trunk? Anybody got any objections to > > installing it? > > > > It should also have an entry in NEWS, I think. > > This is a gentle ping. Can we install this? I'd like to hear Stefan's comments. Regardless, the doc string of diff--wrap-hunk-navigation is not according to our coding style, so please fix it. Also, I don't quite understand why you need changes like this one: - (diff-hunk-next)))))) + (call-interactively 'diff-hunk-next)))))) and the whole issue of testing called-interactively-p that goes with it. Can you explain? Thanks.