From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21391: 24.5; `thing-at-point' should return a string Date: Mon, 14 Nov 2016 17:34:08 +0200 Message-ID: <83a8d2hy8f.fsf@gnu.org> References: <83pom7gjhl.fsf@gnu.org> <0a8d76e4-4d1b-a26d-2b76-a2d9384d9f72@yandex.ru> <83mvhbgitf.fsf@gnu.org> <25bb22e8-1388-275a-d0da-7e698acdf6da@yandex.ru> <83inrygggr.fsf@gnu.org> <83y40sfyij.fsf@gnu.org> <76505436-e66c-0ed3-6d7a-ce654f38ef30@yandex.ru> <83bmxnfhbi.fsf@gnu.org> <73600483-1df5-597c-6066-232189bbdd4a@yandex.ru> <834m3ffeb9.fsf@gnu.org> <83twbfdvav.fsf@gnu.org> <73be4b9d-2df8-cc83-b873-398cb7dd043b@yandex.ru> <83pom3ds3e.fsf@gnu.org> <83bmxme12w.fsf@gnu.org> <834m3edqyr.fsf@gnu.org> <6dbea00c-3bde-6ec3-b109-7aa205bedb5f@yandex.ru> <8337iydq8z.fsf@gnu.org> <83y40qc9jv.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1479137739 30247 195.159.176.226 (14 Nov 2016 15:35:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 14 Nov 2016 15:35:39 +0000 (UTC) Cc: tino.calancha@gmail.com, dgutov@yandex.ru, 21391@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 14 16:35:32 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6JHp-0004No-F7 for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Nov 2016 16:35:09 +0100 Original-Received: from localhost ([::1]:40880 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6JHs-0006vd-PQ for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Nov 2016 10:35:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6JHm-0006tp-Sl for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2016 10:35:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6JHi-0005gS-Is for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2016 10:35:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41855) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c6JHi-0005gL-FV for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2016 10:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c6JHi-0004Wl-8N for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2016 10:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Nov 2016 15:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21391 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21391-submit@debbugs.gnu.org id=B21391.147913764917329 (code B ref 21391); Mon, 14 Nov 2016 15:35:02 +0000 Original-Received: (at 21391) by debbugs.gnu.org; 14 Nov 2016 15:34:09 +0000 Original-Received: from localhost ([127.0.0.1]:57254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6JGr-0004VR-LQ for submit@debbugs.gnu.org; Mon, 14 Nov 2016 10:34:09 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6JGq-0004VC-It for 21391@debbugs.gnu.org; Mon, 14 Nov 2016 10:34:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6JGi-0005Du-5i for 21391@debbugs.gnu.org; Mon, 14 Nov 2016 10:34:03 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6JGi-0005Dk-35; Mon, 14 Nov 2016 10:34:00 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1883 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c6JGf-00046R-FS; Mon, 14 Nov 2016 10:33:57 -0500 In-reply-to: (message from Drew Adams on Sun, 13 Nov 2016 18:43:52 -0800 (PST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125685 Archived-At: > Date: Sun, 13 Nov 2016 18:43:52 -0800 (PST) > From: Drew Adams > Cc: 21391@debbugs.gnu.org > > d> 2. Make `thing-at-point', as before, return just what the > firat `if' clause returns, if that clause is taken. > IOW, move the removal of text properties (from non-nil > NO-PROPERTIES) into the second `if' clause. Why would we want to do that? AFAIU, it would require the function that is the value of the thing-at-point property to second-guess what the caller of thing-at-point wants, something it has no means to do. If thing-at-point is called with NO-PROPERTIES non-nil, and the thing-at-point property returns a string, then any properties should be removed from that string, exactly as in the other case. I don't see why we should single out that one use case. I think the only change that makes sense at this point is to replace sequencep by stringp, as Tino originally proposed. Other than that, there are no problems here that we need to solve.