From: Eli Zaretskii <eliz@gnu.org>
To: Reuben Thomas <rrt@sc3d.org>
Cc: 25230@debbugs.gnu.org
Subject: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for CASECHARS in built-in dictionaries
Date: Wed, 21 Dec 2016 19:15:27 +0200 [thread overview]
Message-ID: <83a8bp2ogg.fsf@gnu.org> (raw)
In-Reply-To: <CAOnWdoj369qH0qOA1s+kQfNDMzj-h_+1ZZT7WUCR4bZNy2f95g@mail.gmail.com> (message from Reuben Thomas on Wed, 21 Dec 2016 00:20:27 +0000)
> From: Reuben Thomas <rrt@sc3d.org>
> Date: Wed, 21 Dec 2016 00:20:27 +0000
> Cc: 25230@debbugs.gnu.org
>
> Here's an updated patch, which simply removes the overriding of the built-in
> CASECHARS/NOT-CASECHARS settings for ispell dictionaries. It assumes that all other dictionaries (either
> configured by the user or found by the various auto-scanning functions) will have sensible
> CASECHARS/NOT-CASECHARS values, which is expected to be the case at present.
Looks like you sent the wrong patch, as this:
> diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el
> index 23ee412..82e5c2b 100644
> --- a/lisp/textmodes/ispell.el
> +++ b/lisp/textmodes/ispell.el
> @@ -436,114 +436,70 @@ ispell-dictionary-base-alist
> ;; The default dictionary. It may be English.aff, or any other
> ;; dictionary depending on locale and such things. We should probably
> ;; ask ispell what dictionary it's using, but until we do that, let's
> - ;; just use a minimal regexp. [:alpha:] will later be set if possible.
> - "[A-Za-z]" "[^A-Za-z]" "[']" nil ("-B") nil iso-8859-1)
> + ;; just use a minimal regexp.
> + "[[:alpha:]]" "[^[:alpha:]]" "[']" nil ("-B") nil iso-8859-1)
> ("american" ; Yankee English
> - "[A-Za-z]" "[^A-Za-z]" "[']" nil ("-B") nil iso-8859-1)
> + "[[:alpha:]]" "[^[:alpha:]]" "[']" nil ("-B") nil iso-8859-1)
> ("brasileiro" ; Brazilian mode
> - "[A-Z\301\311\315\323\332\300\310\314\322\331\303\325\307\334\302\312\324a-z\341\351\355\363\372\340\350\354\362\371\343\365\347\374\342\352\364]"
> - "[^A-Z\301\311\315\323\332\300\310\314\322\331\303\325\307\334\302\312\324a-z\341\351\355\363\372\340\350\354\362\371\343\365\347\374\342\352\364]"
> - "[']" nil nil nil iso-8859-1)
> + "[[:alpha:]]" "[^[:alpha:]]" "[']" nil nil nil iso-8859-1)
leaves the overriding in place. Am I missing something?
next prev parent reply other threads:[~2016-12-21 17:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 12:28 bug#25230: Patch to ispell.el to simplify use of [:alpha:] for CASECHARS in built-in dictionaries Reuben Thomas
2016-12-19 16:23 ` Eli Zaretskii
2016-12-19 21:17 ` Reuben Thomas
2016-12-20 15:37 ` Eli Zaretskii
2016-12-20 18:42 ` Reuben Thomas
2016-12-20 19:37 ` Eli Zaretskii
2016-12-20 21:45 ` Reuben Thomas
2016-12-21 0:20 ` Reuben Thomas
2016-12-21 17:15 ` Eli Zaretskii [this message]
2016-12-21 17:31 ` Reuben Thomas
2016-12-21 18:03 ` Eli Zaretskii
2016-12-21 22:33 ` Reuben Thomas
2019-06-24 23:08 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a8bp2ogg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=25230@debbugs.gnu.org \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).