From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27238: 24.5; Rename `face-spec-set-2' and give it a better doc string Date: Mon, 05 Jun 2017 21:43:25 +0300 Message-ID: <83a85m9sxe.fsf@gnu.org> References: <<<<<<06a7cc83-a2a8-45a0-97d4-bd3a478aab92@default>>>>>> <<<<<<83wp8ra9g6.fsf@gnu.org>>>>>> <<<<<26a213b3-908e-43b1-a009-b8a18f0a1c23@default>>>>> <<<<<83tw3v9njh.fsf@gnu.org>>>>> <<<>>> <<<<83lgp6a257.fsf@gnu.org>>>> <<<139eede5-534a-47ad-805a-bad9995526eb@default>>> <<<83d1ai9yy1.fsf@gnu.org>>> <<2ceee035-593d-4831-be30-06443ba3bc92@default>> <<83bmq29x63.fsf@gnu.org>> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1496688254 939 195.159.176.226 (5 Jun 2017 18:44:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Jun 2017 18:44:14 +0000 (UTC) Cc: 27238@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 05 20:44:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHwz0-0008FK-OS for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Jun 2017 20:44:06 +0200 Original-Received: from localhost ([::1]:34679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHwz5-0005R9-Se for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Jun 2017 14:44:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHwz0-0005R1-KU for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 14:44:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHwyw-0006kX-Ez for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 14:44:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55366) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHwyw-0006kM-CM for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 14:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dHwyw-0006UA-2X for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 14:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Jun 2017 18:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27238 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27238-submit@debbugs.gnu.org id=B27238.149668822624898 (code B ref 27238); Mon, 05 Jun 2017 18:44:02 +0000 Original-Received: (at 27238) by debbugs.gnu.org; 5 Jun 2017 18:43:46 +0000 Original-Received: from localhost ([127.0.0.1]:58042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHwyf-0006TW-TO for submit@debbugs.gnu.org; Mon, 05 Jun 2017 14:43:46 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHwye-0006TH-6v for 27238@debbugs.gnu.org; Mon, 05 Jun 2017 14:43:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHwyU-0006O1-Nj for 27238@debbugs.gnu.org; Mon, 05 Jun 2017 14:43:38 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHwyU-0006Nw-KR; Mon, 05 Jun 2017 14:43:34 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1728 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dHwyT-0004rY-Tr; Mon, 05 Jun 2017 14:43:34 -0400 In-reply-to: (message from Drew Adams on Mon, 5 Jun 2017 10:56:13 -0700 (PDT)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133313 Archived-At: > Date: Mon, 5 Jun 2017 10:56:13 -0700 (PDT) > From: Drew Adams > Cc: 27238@debbugs.gnu.org > > (I still suggest fixing the doc string of `face-spec-set-2', as it is > misleading about its "SPEC" arg.) I'm not sure I understand why it's misleading. You said: > Wrt the doc, the SPEC arg is apparently NOT a face spec, i.e., a spec > such as is returned by (get FACE 'face-defface-spec). Instead, it seems > to be an attributes list such as what is returned by `face-spec-choose' > or `face-attr-construct'. However, "face spec" is described in '(elisp)Defining Faces' as and alist whose elements each have the form (DISPLAY . PLIST) and I believe the SPEC argument accepted by face-spec-choose has this form. The argument received by face-spec-set-2 is just the PLIST which matches the frame's display, i.e. a simple list. So what would you want the doc string to say about this?