From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27470: 26.0.50; this-command-keys and interactive input Date: Sat, 22 Jul 2017 11:16:32 +0300 Message-ID: <83a83wantr.fsf@gnu.org> References: <87y3siapuw.fsf@drachen> <831sq9vphe.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1500711433 31726 195.159.176.226 (22 Jul 2017 08:17:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Jul 2017 08:17:13 +0000 (UTC) Cc: 27470@debbugs.gnu.org To: michael_heerdegen@web.de Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 22 10:17:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYpb0-0007oL-UT for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Jul 2017 10:17:07 +0200 Original-Received: from localhost ([::1]:46098 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYpb4-00026v-J5 for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Jul 2017 04:17:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYpaz-00026o-FY for bug-gnu-emacs@gnu.org; Sat, 22 Jul 2017 04:17:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYpaw-00034p-B3 for bug-gnu-emacs@gnu.org; Sat, 22 Jul 2017 04:17:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49155) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dYpaw-00034M-7y for bug-gnu-emacs@gnu.org; Sat, 22 Jul 2017 04:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dYpav-0006Di-Sw for bug-gnu-emacs@gnu.org; Sat, 22 Jul 2017 04:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jul 2017 08:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27470 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27470-submit@debbugs.gnu.org id=B27470.150071140823888 (code B ref 27470); Sat, 22 Jul 2017 08:17:01 +0000 Original-Received: (at 27470) by debbugs.gnu.org; 22 Jul 2017 08:16:48 +0000 Original-Received: from localhost ([127.0.0.1]:51832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYpai-0006DE-Ge for submit@debbugs.gnu.org; Sat, 22 Jul 2017 04:16:48 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:32847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYpah-0006D1-3i for 27470@debbugs.gnu.org; Sat, 22 Jul 2017 04:16:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYpaY-0002ep-UD for 27470@debbugs.gnu.org; Sat, 22 Jul 2017 04:16:42 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYpaY-0002eg-QW; Sat, 22 Jul 2017 04:16:38 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3334 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dYpaX-0007qG-I9; Sat, 22 Jul 2017 04:16:38 -0400 In-reply-to: <831sq9vphe.fsf@gnu.org> (message from Eli Zaretskii on Sat, 24 Jun 2017 10:01:17 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134846 Archived-At: > Date: Sat, 24 Jun 2017 10:01:17 +0300 > From: Eli Zaretskii > Cc: 27470@debbugs.gnu.org > > > From: Michael Heerdegen > > Date: Sat, 24 Jun 2017 07:58:47 +0200 > > > > (defun test (arg) > > (interactive (list (read-from-minibuffer "Input: "))) > > (message "%S" (cons this-command (this-command-keys))) > > arg) > > > > (global-set-key [f12] #'test) > > > > where f12 stands for some random key sequence. > > > > Hit f12 and give any input. I get the following message: > > > > (test . "^M") > > > > I would expect (test . f12). > > This happens because read-from-minibuffer enters recursive-edit, and > we don't preserve this-command-keys across recursive-edit invocations. > > This has been Emacs behavior since forever. > > The patch below seems to fix this, but I have no idea what it could > break, given how old this behavior is. So if we are to accept this, > I'd like to have a few people step forward and run with the change for > a month or so, to see there are no adverse effects. We've been burnt > several times lately by changes in keyboard-input stuff that broke > subtle but very useful features. Michael, any findings so far? Do you recommend that we push that change? Thanks.