From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28033: [PATCH] Add new face 'header-line-highlight' Date: Sat, 12 Aug 2017 10:20:03 +0300 Message-ID: <83a835qml8.fsf@gnu.org> References: <87bmno7228.fsf@lylat> <83k22crrfg.fsf@gnu.org> <874ltg6l2k.fsf@lylat> <83k22aqdwd.fsf@gnu.org> <87mv75iwn9.fsf@lylat> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1502522473 19731 195.159.176.226 (12 Aug 2017 07:21:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 12 Aug 2017 07:21:13 +0000 (UTC) Cc: 28033-done@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 12 09:21:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgQjL-0004iP-Ad for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Aug 2017 09:21:07 +0200 Original-Received: from localhost ([::1]:33195 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgQjR-0003kq-Aj for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Aug 2017 03:21:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgQjK-0003iq-Rc for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2017 03:21:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgQjG-0007ZR-S4 for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2017 03:21:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47587) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dgQjG-0007ZE-On for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2017 03:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dgQjG-0001Z2-GU for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2017 03:21:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Aug 2017 07:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 28033 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 28033@debbugs.gnu.org, eliz@gnu.org, agrambot@gmail.com Original-Received: via spool by 28033-done@debbugs.gnu.org id=D28033.15025224245976 (code D ref 28033); Sat, 12 Aug 2017 07:21:02 +0000 Original-Received: (at 28033-done) by debbugs.gnu.org; 12 Aug 2017 07:20:24 +0000 Original-Received: from localhost ([127.0.0.1]:56267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgQie-0001YK-Gi for submit@debbugs.gnu.org; Sat, 12 Aug 2017 03:20:24 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgQic-0001YE-G8 for 28033-done@debbugs.gnu.org; Sat, 12 Aug 2017 03:20:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgQiT-00077c-7I for 28033-done@debbugs.gnu.org; Sat, 12 Aug 2017 03:20:17 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgQiT-00077W-3A; Sat, 12 Aug 2017 03:20:13 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1398 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dgQiS-00086f-FP; Sat, 12 Aug 2017 03:20:12 -0400 In-reply-to: <87mv75iwn9.fsf@lylat> (message from Alex on Fri, 11 Aug 2017 16:10:02 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135671 Archived-At: > From: Alex > Cc: 28033@debbugs.gnu.org > Date: Fri, 11 Aug 2017 16:10:02 -0600 > > > Thanks, this makes sense. But please add some of this rationale to > > the documentation. > > I'm not sure exactly what you're looking for, but I added a brief > explanation to the doc. That's what I was looking for (although I made minor wording changes in the actual commit). > > Also, it is preferable to have the first line of a NEWS item be a full > > sentence, if possible. In this case, I would just say > > > > ** New face 'header-line-highlight'. > > > > and then follow that by the details. > > Sure. It seems that a lot of nearby entries don't follow that style, > though... Yes, something to work on. Patches welcome. I've pushed the changes. A couple of minor comments for the future: . Please mention the bug number in the log message. . The order of the references to various parts of the changes in the log message should assume the reading order of top to bottom, so the log message might need some minor reordering. In this case, your original order: > * doc/emacs/display.texi (Standard Faces): > * etc/NEWS: Document the face. > * lisp/emacs-lisp/tabulated-list.el (tabulated-list-init-header): > * lisp/info.el (Info-fontify-node): Use the face. > * lisp/faces.el: Define the face. refers to "the face" before it was defined. I've reordered it to put the reference to the lisp/faces.el change before all the rest. Thanks again for working on this.