From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27871: 26.0.50; Bad handling of unmounted directory Date: Sat, 23 Sep 2017 13:39:29 +0300 Message-ID: <83a81lbswu.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1506163211 14757 195.159.176.226 (23 Sep 2017 10:40:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 23 Sep 2017 10:40:11 +0000 (UTC) Cc: 27871@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 23 12:40:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvhqw-0003Og-P3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Sep 2017 12:40:06 +0200 Original-Received: from localhost ([::1]:34388 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvhr2-00053H-Jk for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Sep 2017 06:40:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvhqx-000523-IM for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 06:40:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvhqs-0003FL-L5 for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 06:40:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44847) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dvhqs-0003F9-HZ for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 06:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dvhqs-0002iT-Ay for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 06:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Sep 2017 10:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27871-submit@debbugs.gnu.org id=B27871.150616318910416 (code B ref 27871); Sat, 23 Sep 2017 10:40:02 +0000 Original-Received: (at 27871) by debbugs.gnu.org; 23 Sep 2017 10:39:49 +0000 Original-Received: from localhost ([127.0.0.1]:53528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvhqf-0002hw-1o for submit@debbugs.gnu.org; Sat, 23 Sep 2017 06:39:49 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvhqd-0002hj-J0 for 27871@debbugs.gnu.org; Sat, 23 Sep 2017 06:39:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvhqT-00033J-AU for 27871@debbugs.gnu.org; Sat, 23 Sep 2017 06:39:42 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvhqT-00033C-7F; Sat, 23 Sep 2017 06:39:37 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2136 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dvhqR-00040z-Np; Sat, 23 Sep 2017 06:39:37 -0400 In-reply-to: (message from Philipp Stephani on Sat, 23 Sep 2017 10:19:19 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137270 Archived-At: > From: Philipp Stephani > Date: Sat, 23 Sep 2017 10:19:19 +0000 > > Here's a patch. With the patch, the output is > > Error getting directory: Transport endpoint is not connected > Warning (initialization): Error setting default-directory > Ignoring relative file name (a) due to nil default-directory Thanks. > +/* Return the current working directory. The result should be freed > + with 'free'. Return NULL on errors. */ > +char * > +emacs_get_current_dir_name (void) > +{ > + char *dir = emacs_get_current_dir_name_1 (); > + if (dir == NULL) > + return NULL; > + /* On Linux, getcwd and get_current_dir_name return a string > + starting with "(unreachable)" if the current directory doesn't > + exist, e.g. because it was unmounted. Treat that as an error. > + See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27871. */ > + const char *prefix = "(unreachable)"; > + size_t dir_len = strlen (dir); > + size_t prefix_len = strlen (prefix); > + if (dir_len >= prefix_len && strncmp (dir, prefix, prefix_len) == 0) > + { > + errno = ENOTCONN; > + return NULL; What if there's a directory called literally "(unreachable)SOMETHING"? This isn't disallowed on GNU/Linux, is it? We should probably stat the result if we see this prefix, before we declare it a failure, IMO.