From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28855: 26.0.90; display-line-numbers-mode does not respect (line|wrap)-prefix '(space :align-to N) text property Date: Tue, 17 Oct 2017 05:44:51 +0300 Message-ID: <83a80qfq70.fsf@gnu.org> References: <1508125091.3713406.1139815176.12F59A69@webmail.messagingengine.com> <83po9nf58h.fsf@gnu.org> <1508201231.2707210.1141020784.023AF671@webmail.messagingengine.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1508208377 16876 195.159.176.226 (17 Oct 2017 02:46:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 17 Oct 2017 02:46:17 +0000 (UTC) Cc: 28855@debbugs.gnu.org, dgutov@yandex.ru To: Paul Rankin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 17 04:46:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4HtN-000327-9V for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Oct 2017 04:46:05 +0200 Original-Received: from localhost ([::1]:36181 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4HtS-0005sj-WF for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 22:46:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4HtN-0005sb-Gi for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 22:46:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4HtK-0001CN-ED for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 22:46:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35874) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4HtK-0001CJ-A3 for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 22:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e4HtK-00010m-2i for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 22:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Oct 2017 02:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28855-submit@debbugs.gnu.org id=B28855.15082083193830 (code B ref 28855); Tue, 17 Oct 2017 02:46:02 +0000 Original-Received: (at 28855) by debbugs.gnu.org; 17 Oct 2017 02:45:19 +0000 Original-Received: from localhost ([127.0.0.1]:44555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4Hsd-0000zi-Cq for submit@debbugs.gnu.org; Mon, 16 Oct 2017 22:45:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4Hsb-0000zV-6H for 28855@debbugs.gnu.org; Mon, 16 Oct 2017 22:45:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4HsT-0000lK-1R for 28855@debbugs.gnu.org; Mon, 16 Oct 2017 22:45:12 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4HsS-0000lF-UV; Mon, 16 Oct 2017 22:45:08 -0400 Original-Received: from [176.228.60.248] (port=2523 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e4HsS-0003la-BX; Mon, 16 Oct 2017 22:45:08 -0400 In-reply-to: <1508201231.2707210.1141020784.023AF671@webmail.messagingengine.com> (message from Paul Rankin on Tue, 17 Oct 2017 10:47:11 +1000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138572 Archived-At: > From: Paul Rankin > Cc: Dmitry Gutov , 28855@debbugs.gnu.org > Date: Tue, 17 Oct 2017 10:47:11 +1000 > > On Tue, 17 Oct 2017, at 02:05 AM, Eli Zaretskii wrote: > > Right, :align-to still counts from the window edge, even when line > > numbers are displayed, whereas you expected it to count from the end > > of the line-number display. > > linum-mode.el (in 26.x) manages to display line numbers without interfering, so it’s really just about display-line-numbers-mode. Yes, of course. linum-mode displays the numbers in the display margin, and keeping off the margins was an explicit design goal of display-line-numbers-mode. > > When this was briefly discussed during development, we decided not to > > change the reported window dimensions and geometry, including those of > > the text area, to account for the screen estate taken by the > > line-number display. But maybe :align-to should be an exception, when > > used to align buffer text (as opposed to header-line or mode-line)? > > Though I'm bothered whether some users of :align-to may not want this > > automatic offset. :align-to is a very popular feature; does anyone > > know or imagine why a Lisp program would NOT like such an offset? > > Citing other discussions is not really relevant, if there’s a problem there’s a problem. User expectation is if a user writes codes following the Elisp manual, the expectation is that it should continue to work. In this case, using :align-to should align to its specified value. :align-to does align to its value, it just doesn't currently update it to account for the space taken by line numbers. It's clear that the change I have in mind will solve your specific problem, I just want to hear from others whether it could harm something.