From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Jensen <aaronjensen@gmail.com>
Cc: alptekin.aker@gmail.com, 30553@debbugs.gnu.org
Subject: bug#30553: 26.0.91; underline appears beneath line-spacing rather than beneath text
Date: Tue, 27 Feb 2018 18:18:18 +0200 [thread overview]
Message-ID: <83a7vu1k51.fsf@gnu.org> (raw)
In-Reply-To: <CAHyO48z61Lra24+HXjJ_8wtU_2z-v4bciEOy7JA-69N481Zojg@mail.gmail.com> (message from Aaron Jensen on Tue, 27 Feb 2018 06:19:00 -0800)
> From: Aaron Jensen <aaronjensen@gmail.com>
> Date: Tue, 27 Feb 2018 06:19:00 -0800
> Cc: Alp Aker <alptekin.aker@gmail.com>, 30553@debbugs.gnu.org
>
> Patch for buffer local underline position variables. I ended up making
> underline-minimum-offset buffer local capable as well.
Does that mean that underline-minimum-offset allows you to avoid
problems with underline overwriting the descents?
> + unsigned long minimum_offset =
> + buffer_local_value (Qunderline_minimum_offset, s->w->contents);
This isn't right. buffer_local_value returns a Lisp object, not an
integer, so you need to convert it to an integer (or a boolean for
other variables). And it can also return the symbol Qunbound, in
which case we need a fallback. So we need something like
Lisp_Object val = buffer_local_value (Qunderline_minimum_offset,
s->w->contents);
if (INTEGERP (val))
minimum_offset = XFASTINT (val);
else
minimum_offset = 1;
and similarly with other variables (except that a boolean variable
will return a value of Qt or Qnil, not a number).
> + DEFSYM (Qunderline_minimum_offset, "underline-minimum-offset");
I think this symbol should be in xdisp.c, where the variable is
defined.
next prev parent reply other threads:[~2018-02-27 16:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 18:16 bug#30553: 26.0.91; underline appears beneath line-spacing rather than beneath text Aaron Jensen
2018-02-20 19:33 ` Eli Zaretskii
2018-02-20 19:44 ` Aaron Jensen
2018-02-21 1:46 ` Alp Aker
2018-02-21 4:23 ` Eli Zaretskii
2018-02-21 4:27 ` Aaron Jensen
2018-02-21 5:01 ` Alp Aker
2018-02-21 6:03 ` Aaron Jensen
2018-02-21 13:47 ` Alp Aker
2018-02-21 16:17 ` Aaron Jensen
2018-02-21 17:56 ` Eli Zaretskii
2018-02-22 2:15 ` Aaron Jensen
2018-02-22 6:26 ` Eli Zaretskii
2018-02-22 6:29 ` Aaron Jensen
2018-02-22 7:21 ` Eli Zaretskii
2018-02-25 22:09 ` Aaron Jensen
2018-02-26 15:42 ` Eli Zaretskii
2018-02-26 16:01 ` Aaron Jensen
2018-02-26 19:25 ` Eli Zaretskii
2018-02-26 20:21 ` Aaron Jensen
2018-02-26 20:41 ` Eli Zaretskii
2018-02-26 20:46 ` Eli Zaretskii
2018-02-26 21:05 ` Aaron Jensen
2018-02-27 14:19 ` Aaron Jensen
2018-02-27 16:18 ` Eli Zaretskii [this message]
2018-02-28 15:19 ` Aaron Jensen
2018-02-28 16:14 ` Eli Zaretskii
2018-02-28 17:41 ` Aaron Jensen
2018-02-28 17:56 ` Eli Zaretskii
2018-03-01 8:36 ` Aaron Jensen
2018-03-08 6:31 ` Aaron Jensen
2018-03-08 13:45 ` Eli Zaretskii
2018-03-10 11:18 ` Eli Zaretskii
2018-03-10 17:47 ` Aaron Jensen
2018-03-10 18:48 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a7vu1k51.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=30553@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
--cc=alptekin.aker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).