From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32337: 26.1; display-line-numbers-mode makes cursor ill-aligned when number face is changed Date: Wed, 01 Aug 2018 10:47:56 +0300 Message-ID: <83a7q6o7df.fsf@gnu.org> References: <87effjtdpw.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1533109570 3368 195.159.176.226 (1 Aug 2018 07:46:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 1 Aug 2018 07:46:10 +0000 (UTC) Cc: 32337@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 01 09:46:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fklpZ-0000g6-8g for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Aug 2018 09:46:01 +0200 Original-Received: from localhost ([::1]:33868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fklrf-0005th-P0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Aug 2018 03:48:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fklrZ-0005tR-7X for bug-gnu-emacs@gnu.org; Wed, 01 Aug 2018 03:48:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fklrW-0007gS-1B for bug-gnu-emacs@gnu.org; Wed, 01 Aug 2018 03:48:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60138) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fklrV-0007g6-TS for bug-gnu-emacs@gnu.org; Wed, 01 Aug 2018 03:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fklrV-00038e-Nd for bug-gnu-emacs@gnu.org; Wed, 01 Aug 2018 03:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Aug 2018 07:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32337 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32337-submit@debbugs.gnu.org id=B32337.153310967612053 (code B ref 32337); Wed, 01 Aug 2018 07:48:01 +0000 Original-Received: (at 32337) by debbugs.gnu.org; 1 Aug 2018 07:47:56 +0000 Original-Received: from localhost ([127.0.0.1]:36923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fklrP-00038K-RQ for submit@debbugs.gnu.org; Wed, 01 Aug 2018 03:47:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fklrO-000386-EK for 32337@debbugs.gnu.org; Wed, 01 Aug 2018 03:47:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fklrG-0007Fg-30 for 32337@debbugs.gnu.org; Wed, 01 Aug 2018 03:47:49 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fklrF-0007FD-Up; Wed, 01 Aug 2018 03:47:46 -0400 Original-Received: from [176.228.60.248] (port=3296 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fklrF-0005Fj-9a; Wed, 01 Aug 2018 03:47:45 -0400 In-reply-to: <87effjtdpw.fsf@gmail.com> (message from Carlos Pita on Tue, 31 Jul 2018 16:19:39 -0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149150 Archived-At: > From: Carlos Pita > Date: Tue, 31 Jul 2018 16:19:39 -0300 > > With the new display-line-numbers-mode, if you customize faces to > something like, say: > > '(line-number ((t (:height 0.85)))) > '(line-number-current-line ((t (:height 0.85)))) > > Then the cursor will be ill-aligned (a bit shifted to the right) when > it's in the last line of the buffer. This line has no number and it > seems to be that the spacing is miscalculated using the default face > size. The empty "line" beyond EOB has the line-number field displayed using the default face, indeed. That's by design: using the same face as for line numbers produces ugly effects, IMO, e.g., if the line-number face defines a background color. So I decided to use the default face for that single place. It doesn't look too bad, IMO, even in the case you reported, as there's no text after the cursor. I'd rather not introduce more complexity (like user options etc.), unless the current display is deemed entirely unacceptable in such cases. Thanks.