From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 32902@debbugs.gnu.org
Subject: bug#32902: Add support for (TIMESTAMP . RESOLUTION) Lisp timestamps
Date: Thu, 04 Oct 2018 19:08:27 +0300 [thread overview]
Message-ID: <83a7nt3dac.fsf@gnu.org> (raw)
In-Reply-To: <13abcc70-0e5b-0d5f-fffc-9b146743a565@cs.ucla.edu> (message from Paul Eggert on Wed, 3 Oct 2018 11:45:12 -0700)
> From: Paul Eggert <eggert@cs.ucla.edu>
> Cc: 32902@debbugs.gnu.org
> Date: Wed, 3 Oct 2018 11:45:12 -0700
>
> > Doc strings only send to
> > the manuals for additional details and explanations, not for the basic
> > facts such as these.
>
> The attached proposed additional patch fixes this by referring to
> format-time-string, and by adding the description of time values to
> format-time-string's doc string. (This is better than the old practice
> of referring to current-time-string, which does not deal with subsecond
> info.) It also fixes some minor doc nits I noticed in additional reading.
>
> > This makes an impression the function doesn't support more than 2
> > arguments, which is incorrect. Can we provide a more accurate 'usage' form?
>
> Yes, and I gave that a shot in the attached patch.
>
> > I think it would be good to add tests for the functions being
> > modified, otherwise we might be breaking something without paying
> > attention.
>
> Good point, and done in the attached.
Thanks.
> > Is it feasible to leave the time-related code in editfns.c?
>
> It's feasible, and I could prepare a patch along those lines. However,
> the time code has has nothing to do with edit functions and is growing
> significantly: the proposed src/systime.c is 56 KiB, which is above the
> median size for src/*.c files. Also, this patch changes the time code so
> much that moving it to a new file won't be that much more of a forensics
> annoyance than leaving it in editfns.c. To my mind the clarity in having
> the time code in its own module outweighs the forensics annoyance.
OK, but can we call the new file something like timefns.c? systime.c
sounds wrong to me (these isn't system-dependent stuff).
next prev parent reply other threads:[~2018-10-04 16:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 1:00 bug#32902: Add support for (TIMESTAMP . RESOLUTION) Lisp timestamps Paul Eggert
2018-10-02 3:04 ` Eli Zaretskii
2018-10-03 18:45 ` Paul Eggert
2018-10-04 16:08 ` Eli Zaretskii [this message]
2018-10-07 6:32 ` Paul Eggert
2018-10-07 17:55 ` Eli Zaretskii
2018-10-07 20:05 ` Paul Eggert
2018-10-08 2:44 ` Eli Zaretskii
2018-10-08 5:18 ` Paul Eggert
2018-10-09 15:09 ` Eli Zaretskii
[not found] ` <3f0bcf06-83f2-a0e9-c9ab-b06d65417afe@cs.ucla.edu>
2018-10-10 3:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a7nt3dac.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32902@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).