unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 35968@debbugs.gnu.org
Subject: bug#35968: Proposed clean-compile patches for release 26.3
Date: Thu, 30 May 2019 17:03:32 +0300	[thread overview]
Message-ID: <83a7f4xcnf.fsf@gnu.org> (raw)
In-Reply-To: <70b1022c-d091-4c32-5683-df1d306baf4b@cs.ucla.edu> (message from Paul Eggert on Wed, 29 May 2019 18:10:24 -0700)

> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Wed, 29 May 2019 18:10:24 -0700
> 
> I propose the attached patches for Emacs 26.3, to help it compile 
> cleanly with more-recent software (GCC 9, librsvg 2.45.1). The idea is 
> mainly to avoid bug reports from people who would otherwise send us 
> these diagnostics. Most of these patches are already in master; the 
> exceptions (patches 2 and 5) are for parts of Emacs that are typically 
> not compiled in master.

Thanks.  I'm okay with all these changes, with one possible exception:

> @@ -351,10 +348,6 @@ size_t _bytes_free;
>  /* Are you experienced?  */
>  int __malloc_initialized;
>  
> -#else
> -
> -static struct list _fraghead[BLOCKLOG];
> -
>  #endif /* HYBRID_MALLOC */
>  
>  /* Number of extra blocks to get each time we ask for more core.

This hunk seems to be just an aesthetic cleanup.  Does it cause any
warnings/errors during compilation?  If not, I'd prefer to leave it
out, for paranoia reasons.





  reply	other threads:[~2019-05-30 14:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28 21:13 bug#35968: Release 26.3 npostavs
2019-05-28 22:25 ` Noam Postavsky
2019-05-30 23:07   ` Noam Postavsky
2019-06-06  1:27     ` Noam Postavsky
2019-06-06  2:35       ` Eli Zaretskii
2019-06-11 20:00         ` Nicolas Petton
2019-06-12  2:30           ` Eli Zaretskii
2019-05-29 16:04 ` Eli Zaretskii
2019-05-30  1:10 ` bug#35968: Proposed clean-compile patches for release 26.3 Paul Eggert
2019-05-30 14:03   ` Eli Zaretskii [this message]
2019-05-30 22:30     ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a7f4xcnf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=35968@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).