From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36609: 27.0.50; Possible race-condition in threading implementation Date: Fri, 12 Jul 2019 18:05:46 +0300 Message-ID: <83a7dj2sz9.fsf@gnu.org> References: <87muhks3b5.fsf@hochschule-trier.de> <83muhj2zmb.fsf@gnu.org> <83ims72xcj.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="204416"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36609@debbugs.gnu.org, politza@hochschule-trier.de To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 12 17:19:42 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlxKk-000qhB-Jz for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Jul 2019 17:19:38 +0200 Original-Received: from localhost ([::1]:50388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlx8c-000669-MI for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Jul 2019 11:07:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55191) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlx8a-000663-93 for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 11:07:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlx8Z-0005pg-Bh for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 11:07:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59955) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlx8Z-0005pX-7B for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 11:07:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlx8Y-0002X4-SJ for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 11:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jul 2019 15:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36609 X-GNU-PR-Package: emacs Original-Received: via spool by 36609-submit@debbugs.gnu.org id=B36609.15629439839688 (code B ref 36609); Fri, 12 Jul 2019 15:07:01 +0000 Original-Received: (at 36609) by debbugs.gnu.org; 12 Jul 2019 15:06:23 +0000 Original-Received: from localhost ([127.0.0.1]:40543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlx7u-0002WB-Me for submit@debbugs.gnu.org; Fri, 12 Jul 2019 11:06:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlx7q-0002Vv-Me for 36609@debbugs.gnu.org; Fri, 12 Jul 2019 11:06:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hlx7k-0005GH-V7; Fri, 12 Jul 2019 11:06:13 -0400 Original-Received: from [176.228.60.248] (port=2360 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hlx7c-00013C-OH; Fri, 12 Jul 2019 11:06:12 -0400 In-reply-to: (message from Pip Cet on Fri, 12 Jul 2019 13:51:48 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162787 Archived-At: > From: Pip Cet > Date: Fri, 12 Jul 2019 13:51:48 +0000 > Cc: politza@hochschule-trier.de, 36609@debbugs.gnu.org > > > If this is not the main thread, then the error handlers should be set > > so as to log the error in last_thread_error, and then terminate the > > thread (via exiting the thread function, AFAIR). > > Indeed, that's what happens; but the thread now fails to release the > GLib lock it had previously acquired, so other threads cannot acquire > it again, ever. Then we should make sure we release it when the thread function exits, or before we call Fsignal from post_acquire_global_lock. There's no reason to use the unwind-protect machinery for that, I think.