From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32510: xref-find-definitions should return file names, too Date: Thu, 18 Jul 2019 18:16:23 +0300 Message-ID: <83a7dbweyg.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="73430"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 32510@debbugs.gnu.org To: Ludovic Brenta Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 18 17:17:08 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ho89c-000Iz7-1b for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jul 2019 17:17:08 +0200 Original-Received: from localhost ([::1]:39080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho89a-0004CT-He for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jul 2019 11:17:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44621) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho89X-0004C6-Tu for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 11:17:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ho89W-0003qS-Qj for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 11:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ho89W-0003px-9q for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 11:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ho89W-0005b4-3X for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 11:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2019 15:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.156346300321485 (code B ref 32510); Thu, 18 Jul 2019 15:17:02 +0000 Original-Received: (at 32510) by debbugs.gnu.org; 18 Jul 2019 15:16:43 +0000 Original-Received: from localhost ([127.0.0.1]:54531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho89C-0005aS-JL for submit@debbugs.gnu.org; Thu, 18 Jul 2019 11:16:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho89A-0005aD-Ft for 32510@debbugs.gnu.org; Thu, 18 Jul 2019 11:16:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ho893-0003Tx-PV; Thu, 18 Jul 2019 11:16:34 -0400 Original-Received: from [176.228.60.248] (port=2493 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ho892-0007Av-H2; Thu, 18 Jul 2019 11:16:33 -0400 In-reply-to: (message from Ludovic Brenta on Thu, 18 Jul 2019 16:53:42 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163312 Archived-At: > Date: Thu, 18 Jul 2019 16:53:42 +0200 > From: Ludovic Brenta > > I can confirm that the patch by Eli Zaretskii works, with a > difference compared to find-tag: find-tag opens the first > file whose name matches the searched string whereas > xref-find-definitions opens a new buffer with all matches, > forcing the user to use many keystrokes (or worse: reach > for the mouse :)) to choose a match. That's not what happened to me after the patch. For me, M-. just visited the one file whose name I typed. Can you show the exact sequence of commands you typed, preferably using the Emacs sources and corresponding TAGS tables and file names as the basis, so that I could repeat it here? > I suppose this change of behavior is intentional, consistent > with all other cross-references, and only affects ergonomy; > the patch more importantly restores the functionality that > was previously lost. I cannot tell whether it's intentional until I see the behavior you describe. What I can say is that if there's only one match, xref goes there automatically and immediately, but if there are several candidate matches, xref shows them and allows you to select the one(s) you want. The xref behavior is better when the match you want is not one of the first few, because find-tag required you to continuously type "C-u M-." in that case, and moreover do that blindly, since you had no idea how far away is your match. With xref you can select the match you are after without iterating through all the previous ones. However, I would expect the user to type the full file name in this use case, since that's what this feature is about: finding a file given its name. In that case, both commands behave almost identically. Dmitry, any comments on the patch? I admit I didn't study in detail the role of the PATTERN slot of the object generated by the function where I proposed to make the change, so perhaps I'm missing some use case where the patch will not DTRT? Thanks.