From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37564: [PATCH] don't export LINES and COLUMNS env vars in term to fix ncurses applications Date: Tue, 01 Oct 2019 19:07:30 +0300 Message-ID: <83a7aka1q5.fsf@gnu.org> References: <87y2y5lfnb.fsf@1e0.co.uk> <83eezxatsv.fsf@gnu.org> <87tv8slb6w.fsf@mattleach.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="154303"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37564@debbugs.gnu.org To: Matthew Leach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 01 18:55:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFLQy-000e1h-Sr for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 18:55:33 +0200 Original-Received: from localhost ([::1]:45074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFLQw-0006X7-Ok for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 12:55:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52565) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFKh1-00078M-R2 for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 12:08:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFKh0-0006vr-OJ for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 12:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53974) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFKh0-0006vj-L7 for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 12:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFKh0-000595-FW for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 12:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2019 16:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37564-submit@debbugs.gnu.org id=B37564.156994605919709 (code B ref 37564); Tue, 01 Oct 2019 16:08:02 +0000 Original-Received: (at 37564) by debbugs.gnu.org; 1 Oct 2019 16:07:39 +0000 Original-Received: from localhost ([127.0.0.1]:34555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFKgd-00057p-6O for submit@debbugs.gnu.org; Tue, 01 Oct 2019 12:07:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFKgb-00057c-0m for 37564@debbugs.gnu.org; Tue, 01 Oct 2019 12:07:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iFKgV-0006ft-5s; Tue, 01 Oct 2019 12:07:31 -0400 Original-Received: from [176.228.60.248] (port=1401 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iFKgU-0006f1-H5; Tue, 01 Oct 2019 12:07:31 -0400 In-reply-to: <87tv8slb6w.fsf@mattleach.net> (message from Matthew Leach on Tue, 01 Oct 2019 16:47:35 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168049 Archived-At: > From: Matthew Leach > Cc: 37564@debbugs.gnu.org > Date: Tue, 01 Oct 2019 16:47:35 +0100 > > > Thanks, but I don't think we can make this change unconditionally, > > because not all applications that heed LINES and COLUMNS use ncurses. > > I'm curious as to which programs you are referring? AFAIK, if a program > tries to read the LINES and COLUMNS environment variables, using > `getenv()', they don't exist. What makes you say that? Emacs exports these variables into the environment that is passed to child subprocesses, so those subprocesses will definitely see them using getenv. > Nevertheless, if a program does read the LINES and COLUMNS variables, > these values will be wrong if the window has been resized (try and > compile the attached C snippet and run in term mode while resizing the > window). Should that be considered as a separate bug? We nowadays have window-adjust-process-window-size-function to support that, and term.el is using that. So why isn't it working for you? Maybe you are running a version of Emacs that's too old (AFAICT, you didn't say which one)?