From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38079: On Windows tramp hangs after server-start is called Date: Wed, 06 Nov 2019 18:06:02 +0200 Message-ID: <83a799gfbp.fsf@gnu.org> References: <0bf97a5e-549f-1e8a-4212-5b08ad05f049@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="27498"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38079@debbugs.gnu.org To: Wanrong Lin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 06 17:09:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iSNrt-0006ye-LR for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Nov 2019 17:09:13 +0100 Original-Received: from localhost ([::1]:60730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSNrr-0005pg-SZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Nov 2019 11:09:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54543) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSNpn-000324-GU for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 11:07:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSNpm-0004XJ-A8 for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 11:07:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60511) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSNpm-0004X0-6j for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 11:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iSNpl-0001zb-S1 for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 11:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Nov 2019 16:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38079 X-GNU-PR-Package: emacs Original-Received: via spool by 38079-submit@debbugs.gnu.org id=B38079.15730563947618 (code B ref 38079); Wed, 06 Nov 2019 16:07:01 +0000 Original-Received: (at 38079) by debbugs.gnu.org; 6 Nov 2019 16:06:34 +0000 Original-Received: from localhost ([127.0.0.1]:41099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSNpK-0001yo-6z for submit@debbugs.gnu.org; Wed, 06 Nov 2019 11:06:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSNpJ-0001ya-4W for 38079@debbugs.gnu.org; Wed, 06 Nov 2019 11:06:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iSNpE-0003aw-1Y; Wed, 06 Nov 2019 11:06:28 -0500 Original-Received: from [176.228.60.248] (port=3265 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iSNp3-0008T3-CZ; Wed, 06 Nov 2019 11:06:20 -0500 In-reply-to: <0bf97a5e-549f-1e8a-4212-5b08ad05f049@gmail.com> (message from Wanrong Lin on Tue, 5 Nov 2019 19:52:59 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171027 Archived-At: > From: Wanrong Lin > Date: Tue, 5 Nov 2019 19:52:59 -0500 > > ;; On Windows, after "server-start" is called, somehow (system-name) > will return lower case host name. If the original > ;; (system-name) returns upper case host name now > tramp-restricted-shell-hosts-alist will be out-of-date and cause > ;; tramp not to function properly. > (defadvice server-start (after update-restricted-host-list last activate) >   (setf tramp-restricted-shell-hosts-alist >         (when (memq system-type '(windows-nt)) >           (list (concat "\\`" (regexp-quote (system-name)) "\\'"))))) > > But the proper fix should be to make sure (system-name) always returns > the same string consistently. I found it is this sexp in "server-start" > function that changes the return value of (system-name): > >       (setq server-process >         (apply #'make-network-process ....)) Thanks. However, your proposed solution is very hard to implement (for boring technical reasons), so my suggestion is for Trump to compare system names case insensitively, at least on MS-Windows, with a proper comment to explain why.