From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37922: 26.3; move-file-to-trash puts wrong trash file name at name collision Date: Sat, 16 Nov 2019 14:56:37 +0200 Message-ID: <83a78w6ku2.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="171143"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37922-done@debbugs.gnu.org To: Shingo Tanaka Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 16 13:57:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVxdW-000iQS-3u for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Nov 2019 13:57:10 +0100 Original-Received: from localhost ([::1]:47690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVxdU-0001ee-VP for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Nov 2019 07:57:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37645) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVxdP-0001eT-5s for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 07:57:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVxdO-0005fC-8g for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 07:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57246) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVxdO-0005f2-6F for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 07:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVxdO-000202-3s for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 07:57:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Nov 2019 12:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 37922 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy Mail-Followup-To: 37922@debbugs.gnu.org, eliz@gnu.org, shingo.fg8@gmail.com Original-Received: via spool by 37922-done@debbugs.gnu.org id=D37922.15739090097660 (code D ref 37922); Sat, 16 Nov 2019 12:57:01 +0000 Original-Received: (at 37922-done) by debbugs.gnu.org; 16 Nov 2019 12:56:49 +0000 Original-Received: from localhost ([127.0.0.1]:37833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVxdA-0001zU-MH for submit@debbugs.gnu.org; Sat, 16 Nov 2019 07:56:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVxd7-0001zF-CC for 37922-done@debbugs.gnu.org; Sat, 16 Nov 2019 07:56:48 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iVxd2-0005aO-5h; Sat, 16 Nov 2019 07:56:40 -0500 Original-Received: from [176.228.60.248] (port=1428 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iVxd1-0008Sh-Er; Sat, 16 Nov 2019 07:56:39 -0500 In-reply-to: (message from Shingo Tanaka on Fri, 25 Oct 2019 22:59:28 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171724 Archived-At: > From: Shingo Tanaka > Date: Fri, 25 Oct 2019 22:59:28 +0900 > > When delete-by-moving-to-trash is t and system-move-file-to-trash is not > defined, move-file-to-trash moves the deleted file to system trash can > following freedesktop.org trash can specification. > > In this condition, when a file is deleted and it has the same name as the > one of an already deleted file in trash can, move-file-to-trash generates > another file name by using make-temp-file to avoid the name collision. > Unfortunately, it does put a wrong name with suffix ".trashinfo". > > For example, when 2 "hoge.txt" are deleted, expected files are like: > > /home/myusername/.local/share/Trash/files: > -rw-rw-rw- 1 myusername 10 2019-10-25 20:00 hoge.txt > -rw-rw-rw- 1 myusername 10 2019-10-25 20:00 hoge.txtwmWP0h > > /home/myusername/.local/share/Trash/info: > -rw-rw-rw- 1 myusername 75 2019-10-25 20:00 hoge.txt.trashinfo > -rw------- 1 myusername 75 2019-10-25 20:00 hoge.txtwmWP0h.trashinfo > > However, the reality is the 2nd trash file in files directory is named > wrongly with ".trashinfo" suffix like: > > /home/myusername/.local/share/Trash/files: > -rw-rw-rw- 1 myusername 10 2019-10-25 20:00 hoge.txt > -rw-rw-rw- 1 myusername 10 2019-10-25 20:00 hoge.txtwmWP0h.trashinfo > ^^^^^^^^^ > /home/myusername/.local/share/Trash/info: > -rw-rw-rw- 1 myusername 75 2019-10-25 20:00 hoge.txt.trashinfo > -rw------- 1 myusername 75 2019-10-25 20:00 hoge.txtwmWP0h.trashinfo > > Here is a potential patch. Thanks, I installed this.