From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 38828@debbugs.gnu.org
Subject: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar
Date: Fri, 03 Jan 2020 12:19:42 +0200 [thread overview]
Message-ID: <83a774j0zl.fsf@gnu.org> (raw)
In-Reply-To: <8a08a776-3ac5-b1ae-21f6-9d51ab1bb1bf@gmx.at> (message from martin rudalics on Fri, 3 Jan 2020 10:38:46 +0100)
> Cc: 38828@debbugs.gnu.org
> From: martin rudalics <rudalics@gmx.at>
> Date: Fri, 3 Jan 2020 10:38:46 +0100
>
> > You can see at the end of frame.el we have a list of variables we
> > watch that have nothing to do with debugging.
>
> I noticed that in the meantime. So we could easily add, for example,
> 'scroll-bar-width' to that list and simplify text like the following
>
> If you do not specify a window’s scroll bar settings via
> ‘set-window-scroll-bars’, the buffer-local variables
> ‘vertical-scroll-bar’, ‘horizontal-scroll-bar’, ‘scroll-bar-width’ and
> ‘scroll-bar-height’ in the buffer being displayed control the window’s
> scroll bars. The function ‘set-window-buffer’ examines these variables.
> If you change them in a buffer that is already visible in a window, you
> can make the window take note of the new values by calling
> ‘set-window-buffer’ specifying the same buffer that is already
> displayed.
>
> in the Elisp manual?
Yes, I think so. You can easily try that yourself, though.
> I wonder why Fset_buffer_redisplay apparently doesn't have to call
> bset_redisplay to redisplay_other_windows. What am I missing here?
Probably the fact that prevent_redisplay_optimizations_p is stronger
than windows_or_buffers_changed?
> > Glyph matrices don't care about the pixel size of the window,
>
> ... but when the pixel height grows we may have to allocate new glyph
> rows too, I suppose ...
Yes.
> > they
> > only care about the maximum number of glyph rows they can
> > accommodate. So increasing the size of a mode line has the effect of
> > making the window's glyph matrices use fewer rows (assuming the
> > window's pixel size doesn't change). In addition, a GUI window
> > usually has a matrix allocated for more rows than it actually uses,
> > which is why each matrix has both 'nrows' and 'rows_allocated'
> > members, and the former is likely to be smaller than the latter. When
> > a window's resize
>
> ... where a "resize" includes changes of its buffer's default face
> font, line spacing, the mode line height ...
Right.
> > But I now think that we need to reset the mode_line_p flag even if we
> > reallocate, because the rows which existed before reallocation are
> > copied to the enlarged matrix, so that flag is kept. So I think I
> > will install the patch with that small change.
>
> Works fine now.
Thanks.
next prev parent reply other threads:[~2020-01-03 10:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 9:57 bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar martin rudalics
2019-12-31 16:05 ` martin rudalics
2020-01-01 16:10 ` Eli Zaretskii
2020-01-01 17:49 ` martin rudalics
2020-01-02 14:15 ` Eli Zaretskii
2020-01-02 19:19 ` martin rudalics
2020-01-02 19:58 ` Eli Zaretskii
2020-01-03 7:31 ` Eli Zaretskii
2020-01-03 9:38 ` martin rudalics
2020-01-03 10:19 ` Eli Zaretskii [this message]
2020-01-03 10:43 ` martin rudalics
2020-01-03 13:07 ` Eli Zaretskii
2020-01-03 15:57 ` martin rudalics
2020-01-03 16:08 ` Eli Zaretskii
2020-01-03 16:34 ` martin rudalics
2020-01-03 17:11 ` Eli Zaretskii
2020-01-03 16:30 ` Eli Zaretskii
2020-01-03 17:16 ` martin rudalics
2020-01-04 19:36 ` Amin Bandali
2020-01-04 19:43 ` Eli Zaretskii
2020-01-04 20:25 ` Amin Bandali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a774j0zl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=38828@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).