From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#26911: 25.2; eshell "cd .." doesn't work correctly with TRAMP Date: Sat, 29 Aug 2020 09:31:22 +0300 Message-ID: <83a6yeynd1.fsf@gnu.org> References: <693aa189-03fa-b963-89eb-ce19c51ba325@cs.ucla.edu> <83wo1jz32t.fsf@gnu.org> <83sgc7z220.fsf@gnu.org> <83r1rryrk0.fsf@gnu.org> <47047d69-91aa-fd0d-1510-64ba7c246970@cs.ucla.edu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16248"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 26911@debbugs.gnu.org, mattiase@acm.org, michael.albinus@gmx.de, yegortimoshenko@gmail.com To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 29 08:32:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBuPR-00046m-6V for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Aug 2020 08:32:17 +0200 Original-Received: from localhost ([::1]:59596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBuPP-0002NH-Iz for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Aug 2020 02:32:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBuPC-0002NA-6j for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2020 02:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36297) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBuPB-0007nC-Sz for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2020 02:32:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kBuPB-0007mv-O7 for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2020 02:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Aug 2020 06:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26911 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 26911-submit@debbugs.gnu.org id=B26911.159868270429912 (code B ref 26911); Sat, 29 Aug 2020 06:32:01 +0000 Original-Received: (at 26911) by debbugs.gnu.org; 29 Aug 2020 06:31:44 +0000 Original-Received: from localhost ([127.0.0.1]:47843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBuOt-0007mO-PB for submit@debbugs.gnu.org; Sat, 29 Aug 2020 02:31:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBuOp-0007m6-4r for 26911@debbugs.gnu.org; Sat, 29 Aug 2020 02:31:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49507) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBuOh-0007ki-TP; Sat, 29 Aug 2020 02:31:31 -0400 Original-Received: from [176.228.60.248] (port=4530 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kBuOg-0005xZ-Sf; Sat, 29 Aug 2020 02:31:31 -0400 In-Reply-To: <47047d69-91aa-fd0d-1510-64ba7c246970@cs.ucla.edu> (message from Paul Eggert on Fri, 28 Aug 2020 22:52:28 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186632 Archived-At: > Cc: 26911@debbugs.gnu.org, mattiase@acm.org, michael.albinus@gmx.de, > yegortimoshenko@gmail.com > From: Paul Eggert > Date: Fri, 28 Aug 2020 22:52:28 -0700 > > > That period after the colon following the drive letter shouldn't be > > there. As you may imagine, many Emacs commands are now broken because > > of this. This must be fixed ASAP. > > I installed the attached patch to revert the recent expand-file-changes in the > DOS_NT case, which should fix the problem you mentioned. Thanks, it does. But it produces a different problem: (expand-file-name "." "c:/foo/bar/") => "c:/foo/bar (note the absence of the trailing slash). > This part of fileio.c is hard to follow because of the #ifdef DOS_NT and #ifdef > WINDOWSNT and #ifdef MSDOS and whatnot. How about if we move the > MS-Windows-specific code to a different source file instead of having that > forest of ifdefs in fileio.c? As things stand, it's hard to maintain the > mainline GNU code, because the way everything's arranged the Microsoft-specific > stuff significantly obfuscates everything else. Sorry, I'm not interested in messing with expand-file-name, as the gains are insignificant, if there are any, and the potential problems that could cause are a legion. I actually think that your latest set of changes there was a mistake (for the same reasons), but as long as you are prepared to fix the fallout, I won't actively object. It took us a lot of blood, sweat, and tears to get to the point where we are: that expand-file-name works correctly for all supported systems (including DOS/Windows) and also the remote use case. We all know how one of the gazillion use cases of that function can be easily broken by a seemingly innocent change in its complex code. So I think we should leave that function alone, and any problems with file names (if they indeed are significant) should be fixed elsewhere.