From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 26911@debbugs.gnu.org, mattiase@acm.org, michael.albinus@gmx.de,
yegortimoshenko@gmail.com
Subject: bug#26911: 25.2; eshell "cd .." doesn't work correctly with TRAMP
Date: Sat, 29 Aug 2020 09:31:22 +0300 [thread overview]
Message-ID: <83a6yeynd1.fsf@gnu.org> (raw)
In-Reply-To: <47047d69-91aa-fd0d-1510-64ba7c246970@cs.ucla.edu> (message from Paul Eggert on Fri, 28 Aug 2020 22:52:28 -0700)
> Cc: 26911@debbugs.gnu.org, mattiase@acm.org, michael.albinus@gmx.de,
> yegortimoshenko@gmail.com
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Fri, 28 Aug 2020 22:52:28 -0700
>
> > That period after the colon following the drive letter shouldn't be
> > there. As you may imagine, many Emacs commands are now broken because
> > of this. This must be fixed ASAP.
>
> I installed the attached patch to revert the recent expand-file-changes in the
> DOS_NT case, which should fix the problem you mentioned.
Thanks, it does. But it produces a different problem:
(expand-file-name "." "c:/foo/bar/") => "c:/foo/bar
(note the absence of the trailing slash).
> This part of fileio.c is hard to follow because of the #ifdef DOS_NT and #ifdef
> WINDOWSNT and #ifdef MSDOS and whatnot. How about if we move the
> MS-Windows-specific code to a different source file instead of having that
> forest of ifdefs in fileio.c? As things stand, it's hard to maintain the
> mainline GNU code, because the way everything's arranged the Microsoft-specific
> stuff significantly obfuscates everything else.
Sorry, I'm not interested in messing with expand-file-name, as the
gains are insignificant, if there are any, and the potential problems
that could cause are a legion. I actually think that your latest set
of changes there was a mistake (for the same reasons), but as long as
you are prepared to fix the fallout, I won't actively object.
It took us a lot of blood, sweat, and tears to get to the point where
we are: that expand-file-name works correctly for all supported
systems (including DOS/Windows) and also the remote use case. We all
know how one of the gazillion use cases of that function can be easily
broken by a seemingly innocent change in its complex code. So I think
we should leave that function alone, and any problems with file names
(if they indeed are significant) should be fixed elsewhere.
next prev parent reply other threads:[~2020-08-29 6:31 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 16:15 bug#26911: 25.2; eshell "cd .." doesn't work correctly with TRAMP Yegor Timoshenko
2017-05-13 18:25 ` Michael Albinus
2017-05-13 18:30 ` Yegor Timoshenko
2017-05-15 15:53 ` Michael Albinus
2020-08-26 20:39 ` Paul Eggert
2020-08-27 11:46 ` Michael Albinus
2020-08-27 18:31 ` Mattias Engdegård
2020-08-27 18:38 ` Eli Zaretskii
2020-08-27 18:54 ` Stephen Berman
2020-08-27 21:53 ` Paul Eggert
2020-08-28 6:39 ` Eli Zaretskii
2020-08-28 7:01 ` Eli Zaretskii
2020-08-28 10:48 ` Eli Zaretskii
2020-08-29 5:52 ` Paul Eggert
2020-08-29 6:31 ` Eli Zaretskii [this message]
2020-08-29 16:46 ` Paul Eggert
2020-08-29 16:59 ` Michael Albinus
2020-08-29 18:29 ` Eli Zaretskii
2020-08-29 19:12 ` Michael Albinus
2020-08-29 19:31 ` Eli Zaretskii
2020-08-30 9:46 ` Michael Albinus
2020-08-30 14:14 ` Eli Zaretskii
2020-08-29 18:26 ` Eli Zaretskii
2020-08-29 20:42 ` Paul Eggert
2020-08-30 14:09 ` Eli Zaretskii
2020-08-30 21:39 ` Paul Eggert
2020-08-31 14:58 ` Eli Zaretskii
2020-08-31 18:15 ` Paul Eggert
2020-08-31 18:56 ` Eli Zaretskii
2020-08-31 23:36 ` Paul Eggert
2020-09-01 2:33 ` Eli Zaretskii
2020-09-03 17:27 ` Eli Zaretskii
2020-09-03 17:42 ` Michael Albinus
2020-09-04 11:55 ` Michael Albinus
2020-09-04 12:25 ` Eli Zaretskii
2020-09-04 13:53 ` Michael Albinus
2020-09-04 14:40 ` Eli Zaretskii
2020-09-04 15:20 ` Eli Zaretskii
2020-09-04 15:59 ` Michael Albinus
2020-09-04 17:42 ` Eli Zaretskii
2020-09-05 8:34 ` Michael Albinus
2020-09-05 11:18 ` Eli Zaretskii
2020-09-05 11:32 ` Eli Zaretskii
2020-09-05 15:57 ` Michael Albinus
2020-09-05 16:33 ` Eli Zaretskii
2020-09-05 17:08 ` Eli Zaretskii
2020-09-05 17:36 ` Michael Albinus
2020-09-05 17:56 ` Eli Zaretskii
2020-09-04 16:09 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a6yeynd1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=26911@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=mattiase@acm.org \
--cc=michael.albinus@gmx.de \
--cc=yegortimoshenko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).