From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#6227: Color isearch regexp submatches differently Date: Sun, 20 Sep 2020 19:45:43 +0300 Message-ID: <83a6xkz9ag.fsf@gnu.org> References: <87bpca15ja.fsf@mail.jurta.org> <87wruv1ohr.fsf@mail.jurta.org> <877hmvtn9t.fsf@mail.jurta.org> <874ohyppfs.fsf@mail.jurta.org> <8739ww1tjp.fsf@mail.jurta.org> <87d3vyaodq.fsf@mail.jurta.org> <87hbla4nl4.fsf@mail.jurta.org> <87mu1llak3.fsf@gnus.org> <83lfh50zxa.fsf@gnu.org> <87eemwss3t.fsf@gnus.org> <834kns22q2.fsf@gnu.org> <87sgbcrcgd.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="907"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, lennart.borgman@gmail.com, 6227@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 20 18:47:01 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kK2UO-00005H-PC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 18:47:00 +0200 Original-Received: from localhost ([::1]:59564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kK2UN-0005LB-LX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 12:46:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kK2TU-0004mD-0w for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 12:46:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40945) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kK2TR-0002Xy-Vl for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 12:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kK2TR-0005se-UE for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 12:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Sep 2020 16:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6227 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 6227-submit@debbugs.gnu.org id=B6227.160062035322588 (code B ref 6227); Sun, 20 Sep 2020 16:46:01 +0000 Original-Received: (at 6227) by debbugs.gnu.org; 20 Sep 2020 16:45:53 +0000 Original-Received: from localhost ([127.0.0.1]:52491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kK2TJ-0005sG-Jo for submit@debbugs.gnu.org; Sun, 20 Sep 2020 12:45:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kK2TI-0005s4-38 for 6227@debbugs.gnu.org; Sun, 20 Sep 2020 12:45:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37486) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kK2TC-0002VM-Gv; Sun, 20 Sep 2020 12:45:46 -0400 Original-Received: from [176.228.60.248] (port=3862 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kK2TB-0004HA-Ly; Sun, 20 Sep 2020 12:45:46 -0400 In-Reply-To: (message from Drew Adams on Sun, 20 Sep 2020 09:41:59 -0700 (PDT)) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188519 Archived-At: > Date: Sun, 20 Sep 2020 09:41:59 -0700 (PDT) > From: Drew Adams > Cc: lennart.borgman@gmail.com, 6227@debbugs.gnu.org > > > > (defface isearch > > > '((((class color) (min-colors 88) (background light)) > > > ;; The background must not be too dark, for that means > > > ;; the character is hard to see when the cursor is there. > > > (:background "magenta3" :foreground "lightskyblue1")) > > > > I meant that these deffaces aren't complete -- they look like examples, > > and the examples are taken from the isearch face. > > > > There should be more of them, and they should be complete, and they > > should have better names (isearch-group-1 etc perhaps). > > FWIW, I use simple definitions like this one for the > eight regexp-level faces, not bothering with multiple > kinds of displays. (Not saying that's what isearch.el > should do.) > > (defface isearchp-regexp-level-8 > '((((background dark)) (:background "#12EC00003F0E")) ; a very dark blue > (t (:background "#F6F5FFFFE1E1"))) ; a light yellow > "Face used to highlight subgroup level 8 of your search context. > This highlighting is done during regexp searching whenever > `isearchp-highlight-regexp-group-levels-flag' is non-nil." > :group 'isearch-plus :group 'faces) That's not the same thing at all: your face definition will work with any terminal (through the automatic color translation).