From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44611: Prefix arg for xref-goto-xref Date: Sun, 27 Dec 2020 20:21:39 +0200 Message-ID: <83a6tzkt3g.fsf@gnu.org> References: <87k0up68e4.fsf@mail.linkov.net> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87h7o7bfoe.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29085"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dgutov@yandex.ru, joaotavora@gmail.com, 44611@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 27 19:23:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ktahD-0007Q3-6j for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Dec 2020 19:23:11 +0100 Original-Received: from localhost ([::1]:55070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktahC-0003L2-80 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Dec 2020 13:23:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktah4-0003Ii-5x for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 13:23:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50192) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ktah3-0004jo-Tl for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 13:23:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ktah3-0008Hu-Mj for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 13:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Dec 2020 18:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44611 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 44611-submit@debbugs.gnu.org id=B44611.160909332231755 (code B ref 44611); Sun, 27 Dec 2020 18:23:01 +0000 Original-Received: (at 44611) by debbugs.gnu.org; 27 Dec 2020 18:22:02 +0000 Original-Received: from localhost ([127.0.0.1]:33505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktag5-0008Fw-Q8 for submit@debbugs.gnu.org; Sun, 27 Dec 2020 13:22:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktag4-0008Fg-7M for 44611@debbugs.gnu.org; Sun, 27 Dec 2020 13:22:00 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52769) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktafx-0004fD-OU; Sun, 27 Dec 2020 13:21:53 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2085 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ktafx-0003dq-7s; Sun, 27 Dec 2020 13:21:53 -0500 In-Reply-To: <87h7o7bfoe.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 27 Dec 2020 18:20:01 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196814 Archived-At: > From: Juri Linkov > Cc: dgutov@yandex.ru, joaotavora@gmail.com, 44611@debbugs.gnu.org > Date: Sun, 27 Dec 2020 18:20:01 +0200 > > The notion "conservative" is irrelevant here, because TAB was bound in xref > recently Not so recently: 2 years ago. And by the time Emacs 28 hits the network, it will probably be 4 years. > > This works both ways: if you want TAB to do something other than its > > default, you can rebind it for you, right? > > This is not about my personal preferences. Your original explanation of the rationale was that you always press TAB because you are used to it in Grep buffers. > > I didn't suggest unbinding TAB, I suggested to leave its current > > binding as it was in Emacs 27 and older. > > This would be the worst thing to do. It sounds like no compromise I suggest is acceptable. then I don't know how to solve this disagreement. > > That contradicts what Dmitry said: that the current Xref UI moves away > > of the completion UI, and towards compilation-mode and grep-mode. > > There, deleting the window with C-j will look odd, I think. > > There are two modes: xref-show-xrefs and xref-show-defs. > xref-show-xrefs is similar to grep, whereas xref-show-defs > resembles the Completion UI where C-j makes sense. AFAIU, Dmitry didn't like the proposal to have different bindings in these two modes. > >> > Why not 'q' (for "quit") or 'b' (for "bury")? > >> > >> 'xref-quit-and-goto-xref' also jumps to xref, not only quits, > >> but 'q' and 'b' should only quit. > > > > That's not a catastrophe, but if you want, we could use "C-c C-c" > > instead, as that is used in some other modes for similar effect. > > I think this is a good idea for completion-like xref-show-defs, > but not for grep-like xref-show-xrefs because in grep-mode > 'C-c C-c' is bound to compile-goto-error that doesn't quit window. There are other modes where it does, e.g. message-mode.