From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48264: [PATCH v3 12/15] Set buffer_defaults fields without a default to Qunbound Date: Fri, 07 May 2021 13:42:36 +0300 Message-ID: <83a6p6ddur.fsf@gnu.org> References: <877dkbsj9d.fsf@catern.com> <20210506213346.9730-13-sbaugh@catern.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40771"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48264@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 07 12:43:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lexwv-000ARx-ST for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 12:43:13 +0200 Original-Received: from localhost ([::1]:46490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lexwu-0001RK-RA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 06:43:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lexwk-0001Qw-Hz for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 06:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59789) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lexwk-0003qz-A0 for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 06:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lexwk-00030z-7W for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 06:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 10:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48264 X-GNU-PR-Package: emacs Original-Received: via spool by 48264-submit@debbugs.gnu.org id=B48264.162038417211583 (code B ref 48264); Fri, 07 May 2021 10:43:02 +0000 Original-Received: (at 48264) by debbugs.gnu.org; 7 May 2021 10:42:52 +0000 Original-Received: from localhost ([127.0.0.1]:43102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lexwZ-00030l-Vo for submit@debbugs.gnu.org; Fri, 07 May 2021 06:42:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lexwY-00030d-Kf for 48264@debbugs.gnu.org; Fri, 07 May 2021 06:42:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59992) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lexwR-0003h2-Iv; Fri, 07 May 2021 06:42:45 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1374 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1lexwQ-0001uC-Vw; Fri, 07 May 2021 06:42:43 -0400 In-Reply-To: <20210506213346.9730-13-sbaugh@catern.com> (message from Spencer Baugh on Thu, 6 May 2021 17:33:43 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205912 Archived-At: > From: Spencer Baugh > Date: Thu, 6 May 2021 17:33:43 -0400 > Cc: Spencer Baugh > > * src/buffer.h (BUFFER_DEFAULT_VALUE_P): > Check if field is Qunbound to determine if there's a default. This should be filled with fill-paragraph. > @@ -54,7 +54,8 @@ along with GNU Emacs. If not, see . */ > defined with DEFVAR_PER_BUFFER, that have special slots in each buffer. > The default value occupies the same slot in this structure > as an individual buffer's value occupies in that buffer. > -*/ > + Slots in this structure which are set to Qunbound are permanently > + buffer-local. */ ^^ Two spaces after the period that ends a sentence, please. > @@ -5252,6 +5253,15 @@ init_buffer_once (void) > > /* Set up the default values of various buffer slots. */ > /* Must do these before making the first buffer! */ > + int offset; > + FOR_EACH_PER_BUFFER_OBJECT_AT (offset) > + { > + /* These are initialized before us. */ ^^ Typo: should be "use". Also, please leave two spaces after the period. > + if (!(offset == PER_BUFFER_VAR_OFFSET (syntax_table) > + || offset == PER_BUFFER_VAR_OFFSET (category_table))) Please add a comment here about these two exemptions. (And I cannot say that I like such kludges; why doe we need it?) > + /* Sanity check that we didn't set the default for slots which > + are permanent-buffer-locals. */ ^^ Two spaces again. > --- a/src/buffer.h > +++ b/src/buffer.h > @@ -1102,7 +1102,8 @@ BUFFER_CHECK_INDIRECTION (struct buffer *b) > that have special slots in each buffer. > The default value occupies the same slot in this structure > as an individual buffer's value occupies in that buffer. > -*/ > + Slots in this structure which are set to Qunbound are permanently > + buffer-local. */ ^^ And again.