From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49723: 28.0.50; Test in coding.c for NUL bytes in filenames is not reliable Date: Sat, 18 Sep 2021 09:51:33 +0300 Message-ID: <83a6ka74wa.fsf@gnu.org> References: <83o8ary5kl.fsf@gnu.org> <87pmtbj81v.fsf@gmail.com> <8335q7c655.fsf@gnu.org> <87pmta6buq.fsf@gmail.com> <837dfgaerv.fsf@gnu.org> <8735q4zcdh.fsf@gmail.com> <83fsu38wuw.fsf@gnu.org> <87czp7xc1z.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17928"; mail-complaints-to="usenet@ciao.gmane.io" Cc: phst@google.com, 49723-done@debbugs.gnu.org To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 18 08:52:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRUCs-0004Rn-8p for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 08:52:14 +0200 Original-Received: from localhost ([::1]:58954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRUCq-0005uF-Ti for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 02:52:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRUCg-0005tu-Tr for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 02:52:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50099) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRUCg-0003rQ-Lz for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 02:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRUCg-0005OJ-Gn for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 02:52:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Sep 2021 06:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 49723 X-GNU-PR-Package: emacs Mail-Followup-To: 49723@debbugs.gnu.org, eliz@gnu.org, eliz@gnu.org Original-Received: via spool by 49723-done@debbugs.gnu.org id=D49723.163194791820702 (code D ref 49723); Sat, 18 Sep 2021 06:52:02 +0000 Original-Received: (at 49723-done) by debbugs.gnu.org; 18 Sep 2021 06:51:58 +0000 Original-Received: from localhost ([127.0.0.1]:33411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRUCb-0005Nq-QZ for submit@debbugs.gnu.org; Sat, 18 Sep 2021 02:51:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRUCZ-0005NX-QE for 49723-done@debbugs.gnu.org; Sat, 18 Sep 2021 02:51:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42028) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRUCT-0003eU-PP; Sat, 18 Sep 2021 02:51:49 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3024 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRUCT-00020s-BR; Sat, 18 Sep 2021 02:51:49 -0400 In-Reply-To: <87czp7xc1z.fsf@gmail.com> (message from Federico Tedin on Fri, 17 Sep 2021 21:00:08 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214600 Archived-At: > From: Federico Tedin > Cc: phst@google.com, 49723@debbugs.gnu.org > Date: Fri, 17 Sep 2021 21:00:08 +0200 > > > Thanks. Did you run the test suite after applying the changes, and > > did you see no regressions? If you didn't yet run the test suite, > > please be sure to run all of it, as the use of expand-file-name is > > universal. > > I hadn't, so I checked out master aa59d38c59 and applied my patch on top > of it. I then ran "make check" and waited for a bit. There appears to be > only two tests failing in test/lisp/time-stamp-tests.el > ('time-stamp-format-day-of-week' and > 'time-stamp-format-string-width'). Both seem to be unrelated to my > change; maybe it's my system's strange combination of > Spanish/English/German locale-related configurations (I'm attaching the > log just in case). All other test files were run without problems. Thanks. I installed your changes, and I'm therefore closing this bug. A few minor stylistic comments, for the future . the lines in the commit log message are too wide, they should be at most 66 characters, because we produce ChangeLog files from Girt logs, and ChangeLog files have the fill-column set to 74, which includes 9-column TAB (perhaps this means the fill-column setting in .dire-locals.el should be amended?) . please quote symbols in commit log messages rather than leaving them unquoted (this doesn't apply to symbols in parentheses that state the functions which were changed) . please try to establish whether the changes need to be described in the manual(s), and mark the NEWS entries accordingly (if you decide there's a need to describe in the manual, please also include a suitable change for that) Thanks again for working on this.