From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds Date: Tue, 02 Nov 2021 20:01:19 +0200 Message-ID: <83a6imjv2o.fsf@gnu.org> References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7884"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 02 19:12:49 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhyH9-0001mf-Ml for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 19:12:47 +0100 Original-Received: from localhost ([::1]:56840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhyH8-0000ru-Jy for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 14:12:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhy6k-0008Gn-JD for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 14:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54683) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhy6k-0008Kr-8n for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 14:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mhy6j-0000Ul-Iz for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 14:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Nov 2021 18:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51556 X-GNU-PR-Package: emacs Original-Received: via spool by 51556-submit@debbugs.gnu.org id=B51556.16358760941861 (code B ref 51556); Tue, 02 Nov 2021 18:02:01 +0000 Original-Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 18:01:34 +0000 Original-Received: from localhost ([127.0.0.1]:37996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhy6I-0000Tx-4c for submit@debbugs.gnu.org; Tue, 02 Nov 2021 14:01:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhy6F-0000Tb-28 for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 14:01:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhy68-0007to-Ly; Tue, 02 Nov 2021 14:01:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/p3IGbbu4crPzCcBDkRlYSD6TJtObUI4b48aBuf+skA=; b=nDmEASOZg6qW ghlL86CZ4hlnbdlP+HZ7oUdws9rs3BrJZjRevB8RGyKTp0/+JAq0wjjadSWsDf9anPGv/BfvykVTz cQpAZjZo+tYDKoQkl9tUK1bh9HFIDl4dCO4B/hityhUpAf4YQaBJXvK43xvPQDCrAKgrkRcbv0n+n VTDs+g1c6/xhOJ6waKMh5PxRfk1x5i6ByXAVQaT1sBveCPM0LiBj3vqkBOOOEbctlkzc060xWskNX GM36e4VHdTtSVq/5cWJWfLNTobTmqZsU0XXNlFqTybsIw/81BfGr+LMM7WdlhNG/p29vTXHgALoDk Ou9AZRfjai27uFLSWGG1Kw==; Original-Received: from [87.69.77.57] (port=4565 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhy68-0004Gq-4g; Tue, 02 Nov 2021 14:01:24 -0400 In-Reply-To: (message from Stefan Kangas on Tue, 2 Nov 2021 10:44:23 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218822 Archived-At: > From: Stefan Kangas > Date: Tue, 2 Nov 2021 10:44:23 -0700 > Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com > > > What is the difference between "colors specified by the SVG image" > > (which you say we respect), and "foreground color is specified in the > > SVG file" (which you want us to disregard)? > > You missed quoting "no" in "no foreground color is specified in the SVG > file". So the difference is that in one case the SVG files specifies > the foreground color, in the other case it does not. I didn't miss anything, no. If the solution you propose only works for SVG that specify no foreground, then it won't be able to solve all of the situations where a different theme makes an icon barely visible or unpleasant to the eye. Which is why I think a better solution would be to allow themes to specify different icons where necessary. > >> I consider this a bug fix, but admittedly only a minor one. However, I > >> also note that the visibility of those symbols is worse with a dark > >> theme in Emacs 28 than in Emacs 27, so we might consider it a > >> regression. > > > > Let's not exaggerate, okay? > > I fail to see any exaggeration. > > I've attached two screenshots of the customize buffer using the > "tsdh-dark" theme, one in Emacs 27 and the other one in Emacs 28. If we want to fix this, we can go back to down.xpm etc. on the release branch, and discuss how to solve this on master.