From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52888: 29.0.50; font_{delete_unmatched,score} do not handle nil FONT_WEIGHT_INDEX Date: Thu, 06 Jan 2022 14:29:34 +0200 Message-ID: <83a6g982tt.fsf@gnu.org> References: <87czl55skc.fsf@melete.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40958"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52888@debbugs.gnu.org To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 06 13:31:02 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5Rv3-000AQC-Va for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jan 2022 13:31:02 +0100 Original-Received: from localhost ([::1]:35346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5Rv2-0005Id-At for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jan 2022 07:31:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Ru8-0005H6-Fb for bug-gnu-emacs@gnu.org; Thu, 06 Jan 2022 07:30:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46950) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5Ru6-00082u-Sa for bug-gnu-emacs@gnu.org; Thu, 06 Jan 2022 07:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5Ru6-0005h1-Ma for bug-gnu-emacs@gnu.org; Thu, 06 Jan 2022 07:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jan 2022 12:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52888 X-GNU-PR-Package: emacs Original-Received: via spool by 52888-submit@debbugs.gnu.org id=B52888.164147217121824 (code B ref 52888); Thu, 06 Jan 2022 12:30:02 +0000 Original-Received: (at 52888) by debbugs.gnu.org; 6 Jan 2022 12:29:31 +0000 Original-Received: from localhost ([127.0.0.1]:39853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5Rta-0005fv-Nq for submit@debbugs.gnu.org; Thu, 06 Jan 2022 07:29:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5RtY-0005fj-Tj for 52888@debbugs.gnu.org; Thu, 06 Jan 2022 07:29:29 -0500 Original-Received: from [2001:470:142:3::e] (port=41988 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5RtT-0007rq-Hn; Thu, 06 Jan 2022 07:29:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WZKao3ZbMFa098n7a1U4RYshSPissMS4u1JGIIHrkR8=; b=knkO+nLm7LJz xhlBhsPKay1dZyVl1bODPW61CVKPZauA/rbhjoqC7mtw3wCXflFFn8x+fJMmys9+rBToh+0u+RNei 4hlbKhydG5s0p6io1vPuwK5EQRtJaLd6PcvFzsE/xP6iHUsjHsv+mOTlgGUhd/8jWXWlp64XmqfP+ XtjLXp/PV8rIoZxwJ+5Aj6jpMZtpuKigrWdcvfVU0KOy+omZHnUTIdlAMaY/qNi7luQvxPENrVlwx dP21LzcVFktJ66WqHdDOgoHKFSZRYzzaTpM7ukQbtHX6KOtNc4O4C6oGPZGFyWywlXSnds3Uax78W y6YuM7ksuOoaz9/IOdIzjw==; Original-Received: from [87.69.77.57] (port=3371 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5RtT-0008Rb-EI; Thu, 06 Jan 2022 07:29:23 -0500 In-Reply-To: <87czl55skc.fsf@melete.silentflame.com> (message from Sean Whitton on Wed, 05 Jan 2022 22:41:55 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223730 Archived-At: > From: Sean Whitton > Cc: 52888@debbugs.gnu.org > Date: Wed, 05 Jan 2022 22:41:55 -0700 > > > According to what I see in the documentation, FcPatternGetRange exists > > only since version 2.11.91 of Fontconfig, whereas we support 2.2.0 and > > up. > > Ah, right. Is this version bound written down anywhere other than the > conditionals in configure.ac? Sorry I didn't think to look there. No, I don't think we document the minimum versions of prerequisites anywhere. > > So we cannot unconditionally use that API, and some part of the > > temporary solution will have to be left in the source. I'd need to > > see the final patch with that in mind, before I can decide whether it > > is simple/safe enough for the release branch. > > My patch requires FC_VARIABLE which was not added until 2.12.91, so in > the attached revision I've set up preprocessor conditionals based on > FC_VARIABLE. Checking that FC_VARIABLE is true is how we know it's one > of the virtual entries. OK, but (a) we need a comment there explaining why FC_VARIABLE is used as the condition, and (b) we'd also need to merge the temporary fix in font.c to master. Thanks.