From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53636: 29.0.50; face-remapping broken on master Date: Sun, 30 Jan 2022 21:19:17 +0200 Message-ID: <83a6fd9glm.fsf@gnu.org> References: <87o83tib13.fsf@gnu.org> <871r0p9l4f.fsf@gnus.org> <83ee4p9izg.fsf@gnu.org> <87mtjd8485.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5251"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53636@debbugs.gnu.org, tsdh@gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 30 20:20:48 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEFkl-0001Fb-EJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jan 2022 20:20:47 +0100 Original-Received: from localhost ([::1]:34008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nEFkk-0000Ln-AC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jan 2022 14:20:46 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEFk2-0000Kd-QF for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 14:20:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44778) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nEFk2-0008P4-Fm for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 14:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nEFk2-0005mr-9p for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 14:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jan 2022 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53636 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 53636-submit@debbugs.gnu.org id=B53636.164357037122201 (code B ref 53636); Sun, 30 Jan 2022 19:20:02 +0000 Original-Received: (at 53636) by debbugs.gnu.org; 30 Jan 2022 19:19:31 +0000 Original-Received: from localhost ([127.0.0.1]:37681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEFjX-0005m1-Aq for submit@debbugs.gnu.org; Sun, 30 Jan 2022 14:19:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEFjW-0005lp-1O for 53636@debbugs.gnu.org; Sun, 30 Jan 2022 14:19:30 -0500 Original-Received: from [2001:470:142:3::e] (port=53014 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEFjQ-0008Lx-Ng; Sun, 30 Jan 2022 14:19:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7VpADtca+QduhBsXbh5jN3xbPlLQET+b3RIogMtyn0k=; b=htU9QO9sCuNr WPix+MZXm9tmmiKqO+X8cz+GLHu0u3l0ACVyIMJWADUbWXc6smEYVpwqrwneBwJBWQE/hLww5S8aQ jMy4PikTL3iGBHq4WnsyLmAzTsV7gCmXgptk22J/oBmXN0gWSKKo4ps/FXqRran1Z9BtUyG6mT5Y3 V6KplqQ4vtJcthVtq8gjbtKJ2Pb6tUH+1wALwpAPbd856DrJFodpdo3Ab1Wys3qGOaeXzWwygK/Bf df4JXInsASiNlOoOZQGTBHsqfGWzSfzRnLW8fU0vus3ASilmtI2t20faGt5Ut2ExV1vyF2L3ljyXT wdsY4C3c2Jx17hxHKViWPQ==; Original-Received: from [87.69.77.57] (port=2686 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEFjP-0005r7-RS; Sun, 30 Jan 2022 14:19:24 -0500 In-Reply-To: <87mtjd8485.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 30 Jan 2022 19:31:54 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225626 Archived-At: > From: Lars Ingebrigtsen > Cc: 53636@debbugs.gnu.org, tsdh@gnu.org > Date: Sun, 30 Jan 2022 19:31:54 +0100 > > Eli Zaretskii writes: > > > If the problem is with face remapping, can we please have a reproducer > > that is simpler to debug? Like one that doesn't need any timers and > > flashing text? > > I assumed that all that async stuff was part of the reproducer, but > indeed it's not. > > Just evaling this is sufficient: > > (face-remap-add-relative 'mode-line 'error) > > And this is because mode-line is (in Emacs 29) the parent of two faces > (but not used directly on the mode line), so you apparently have to do > this instead: > > (face-remap-add-relative 'mode-line-active 'error) > > I'm not sure whether that's a bug or not? (That remapping a parent face > has no effect.) But it does have effect. Try "C-x 5 b *scratch* RET" after evaluating the first face-remap-add-relative, and you will see that it does have effect. So it's something more subtle... And yes, I think the extra indirection we now have on master exposed a problem we never saw before.