From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46988: 28.0.50; Documenting and verifying assumptions about C code not calling quit or GCing Date: Mon, 20 Jun 2022 14:47:48 +0300 Message-ID: <83a6a7mu8r.fsf@gnu.org> References: <87zgi8p0vd.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27858"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46988@debbugs.gnu.org, mattiase@acm.org, monnier@iro.umontreal.ca, pipcet@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 20 13:49:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3Fu2-000770-Sa for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jun 2022 13:49:11 +0200 Original-Received: from localhost ([::1]:33206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3Fu1-0006lz-Qr for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jun 2022 07:49:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3Ftu-0006lc-AQ for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2022 07:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60699) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3Ftu-0000wQ-2J for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2022 07:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o3Ftt-0008M0-Sz for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2022 07:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jun 2022 11:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46988 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 46988-submit@debbugs.gnu.org id=B46988.165572569432052 (code B ref 46988); Mon, 20 Jun 2022 11:49:01 +0000 Original-Received: (at 46988) by debbugs.gnu.org; 20 Jun 2022 11:48:14 +0000 Original-Received: from localhost ([127.0.0.1]:54596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3Ft7-0008Ku-NE for submit@debbugs.gnu.org; Mon, 20 Jun 2022 07:48:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3Ft4-0008KQ-70 for 46988@debbugs.gnu.org; Mon, 20 Jun 2022 07:48:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46554) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3Fsy-0000ko-EN; Mon, 20 Jun 2022 07:48:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=qi+ym1X3aRYNrJCuxLc3CTDilhC/OOxt4HjwuLn2wt0=; b=HUsKcx8nSqsMwKsiDTae 4WCI5hWp2mwcLt4MpvcKfrhFBKPA1DW055MZF7yZjNCIrCpErx8NdOEjM7ZoLrZUbVm4TKyBUIOAP ncJOPjuc6Xqlo0ez9SD/EC+yBrhSotlzhqRK0lL45BaSl5iFfJevEovSHiEXQFvkBbJcCtVx6LwYh vW673uN3GkQp2hTAV7fjBkwUvb1SpBbiulWFHUzy0+oCwJelUxwOZrYVirSXpPchBCzzLb026sIon uu0SwhgKgKzRPbwYau6O9pFV4YGAf/b3JNmZOBs1Mw3oTYgSsc9Woo8i0vBVncB6KtXLCbe75Xyop aqj+P4vs1nTbRQ==; Original-Received: from [87.69.77.57] (port=1530 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3Fsw-0003Af-5b; Mon, 20 Jun 2022 07:48:04 -0400 In-Reply-To: <87zgi8p0vd.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 20 Jun 2022 03:41:42 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234872 Archived-At: > Cc: 46988@debbugs.gnu.org, > Mattias Engdegård , > Stefan Monnier > From: Lars Ingebrigtsen > Date: Mon, 20 Jun 2022 03:41:42 +0200 > > Pip Cet writes: > > > Patch attached. It assumes the standard stack growth direction, and > > that __builtin_frame_address (0) is available and works. Uses GCC's > > __attribute__ ((cleanup (...))). > > > > My point here is that the technical implementation isn't the problem, > > the question is whether we're disciplined enough to run with checking > > enabled and react to bug reports about the fatal error being thrown. > > I've respun the patch for the current trunk, and I wonder whether > anybody has any comments here (so I've added Stefan and Mattias to the > CCs). > > I think if we add this, it should be enabled only if the build is > configured with --enable-checking. Yes, I agree. In addition, AFAIU this uses some GCC-specific stuff without providing for other compilers that don't support the same literal features.