From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode Date: Fri, 08 Jul 2022 15:22:11 +0300 Message-ID: <83a69j4wwc.fsf@gnu.org> References: <874jzui52r.fsf@web.de> <87iloa2hlm.fsf@web.de> <87mtdmyrp4.fsf@web.de> <83o7y15vtz.fsf@gnu.org> <87edyxz0as.fsf@web.de> <83czeh5hy9.fsf@gnu.org> <87bku15g5e.fsf@web.de> <835yk959w4.fsf@gnu.org> <87sfndufh3.fsf@web.de> <87o7y1uf03.fsf@web.de> <83y1x452r7.fsf@gnu.org> <875yk795fd.fsf@web.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34800"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56423@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 08 14:23:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9n0q-0008ro-4n for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Jul 2022 14:23:12 +0200 Original-Received: from localhost ([::1]:49300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9n0o-0005uF-El for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Jul 2022 08:23:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9n0g-0005tj-8o for bug-gnu-emacs@gnu.org; Fri, 08 Jul 2022 08:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36913) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9n0f-00067E-VJ for bug-gnu-emacs@gnu.org; Fri, 08 Jul 2022 08:23:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9n0f-0000TT-OW for bug-gnu-emacs@gnu.org; Fri, 08 Jul 2022 08:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Jul 2022 12:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56423 X-GNU-PR-Package: emacs Original-Received: via spool by 56423-submit@debbugs.gnu.org id=B56423.16572829421718 (code B ref 56423); Fri, 08 Jul 2022 12:23:01 +0000 Original-Received: (at 56423) by debbugs.gnu.org; 8 Jul 2022 12:22:22 +0000 Original-Received: from localhost ([127.0.0.1]:59043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9n02-0000Rc-6n for submit@debbugs.gnu.org; Fri, 08 Jul 2022 08:22:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9mzy-0000RB-2g for 56423@debbugs.gnu.org; Fri, 08 Jul 2022 08:22:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38092) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9mzs-00063w-SA; Fri, 08 Jul 2022 08:22:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kWTEGmoh8YpzwbU6FY7L5qA0U9E2o0d4i/hxWGR6NGs=; b=F1RpjeWGYuEv o+Jdhce2bgnzBMGHDyItfLPwj6PGXneN+KT09/JtK+2kmwxaojloTkOMbghWNFBhuvd2fSMVG0aA0 MzSXpe5RJygsI5ii5i7wmjcDRVjIWFVbWxFIG17zfKcQdhRg0aaZKN/4xMh7cvaD+n7OZ9DOVdwpx pLzH1Y1R53/3BmHwETRKJ/pT4kjv59EJZGnM/aaxoM0rYvS3zo5GyfHNTlt9bE2Ws1ppuqh5Mg7K9 nCtgG1HZSuT2hC6N7pvBxoCiH86FHUsGLaoinGpxkmfuairRlCmCig7oiGaVAkW2m4NTfs7OJfq3Y oVJ7yUGee0PRHqtb9COlOQ==; Original-Received: from [87.69.77.57] (port=1182 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9mzs-0002kn-CF; Fri, 08 Jul 2022 08:22:12 -0400 In-Reply-To: <875yk795fd.fsf@web.de> (message from Michael Heerdegen on Fri, 08 Jul 2022 14:04:22 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236449 Archived-At: > From: Michael Heerdegen > Cc: 56423@debbugs.gnu.org > Date: Fri, 08 Jul 2022 14:04:22 +0200 > > Eli Zaretskii writes: > > > Yes, it's okay to inhibit-quit for short intervals of time and around > > small code fragments. > > The direction back (especially `wdired-finish-edit' after making many > changes) is problematic however. If the user aborts when file changes > have been performed partly we have a problem I think. You mean, the display will no longer match the actual situation on disk? Then I think an unwind-protect or condition-case form that resyncs the display in case of a signal is in order, since preventing the user from aborting in that place would be wrong -- what if the user realizes, too late, that some of the changes mean trouble?