From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57150: 29.0.50; [PATCH] Add test coverage for overlay modification hooks Date: Sun, 14 Aug 2022 10:15:08 +0300 Message-ID: <83a687l2ir.fsf@gnu.org> References: <87ilmygjyv.fsf@rfc20.org> <87edxmgjke.fsf@rfc20.org> <83o7wqnfu8.fsf@gnu.org> <87k07bctq1.fsf@rfc20.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35645"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57150@debbugs.gnu.org To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 14 09:16:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oN7rJ-00093w-Mx for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Aug 2022 09:16:29 +0200 Original-Received: from localhost ([::1]:52012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oN7rI-0003R6-Cd for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Aug 2022 03:16:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oN7qt-0003Qu-LQ for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2022 03:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45957) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oN7qs-0008GH-NE for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2022 03:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oN7qs-0000iQ-Dz for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2022 03:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Aug 2022 07:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57150 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57150-submit@debbugs.gnu.org id=B57150.16604613332706 (code B ref 57150); Sun, 14 Aug 2022 07:16:02 +0000 Original-Received: (at 57150) by debbugs.gnu.org; 14 Aug 2022 07:15:33 +0000 Original-Received: from localhost ([127.0.0.1]:35706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oN7qO-0000ha-Ie for submit@debbugs.gnu.org; Sun, 14 Aug 2022 03:15:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oN7qM-0000hO-Tu for 57150@debbugs.gnu.org; Sun, 14 Aug 2022 03:15:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40930) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oN7qH-000820-Go; Sun, 14 Aug 2022 03:15:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QbwuR95LbH88eIQgNBdWL9MPWo287Kl0qoRgwnkojfU=; b=fPdoLQtW/Yy9 EnvdKl4ULSEpDjy5mBw/DpzuKeOxUClv7AwYYW7vE21Tdx+GphSLEyPMN7HsUM42n9x+H+65UXphC itiYbyM/IdzmXR9LCC71nSfkBPIgfH6suC40gTPNWuMVLSG8zRHf4ZLbhQOgp6xugLGECcKweoDKz r/5sGp6GOg8oeh3x2kftIbhai7D40t6JS3Xm+CwmZmWGK6nlmsJGGFqfeQoapi+gXAeWQSji+7p5A iW1vHR2YRSXkjReXOcVQndSv2rTLGeQ/BKSHsbNR4CG+Us/H363DfwhWTkBphsqnk7woM92yIthMy nkLCK4LwjWva4ojUdlrgDw==; Original-Received: from [87.69.77.57] (port=2265 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oN7qG-0004Bt-OZ; Sun, 14 Aug 2022 03:15:25 -0400 In-Reply-To: <87k07bctq1.fsf@rfc20.org> (message from Matt Armstrong on Sat, 13 Aug 2022 21:52:22 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239624 Archived-At: > From: Matt Armstrong > Cc: 57150@debbugs.gnu.org > Date: Sat, 13 Aug 2022 21:52:22 -0700 > > Thanks Eli, another patch attached. More comments below. This is very good, thanks! > Ironically, after all this was done, I am left wondering if a well > designed macro fixture wouldn't be more clear, simply because it does > produce a separate ERT test for each test case. Perhaps there are ways > to design macro test fixtures in clear ways to avoid the downsides of > the way they appear in the other buffer-tests.el tests today.... It is okay to make several tests in a single ert-deftest test, as long as each failing test is clearly explained and easily correlated to the source code that failed.