From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57266: Maintaining the base_line_number cache Date: Mon, 22 Aug 2022 21:35:54 +0300 Message-ID: <83a67w9ldh.fsf@gnu.org> References: <831qteccli.fsf@gnu.org> <834jy4bhqp.fsf@gnu.org> <83y1vga0l5.fsf@gnu.org> <83edx89rl4.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34643"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57266@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 22 21:26:43 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQD4M-0008pK-Ah for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Aug 2022 21:26:42 +0200 Original-Received: from localhost ([::1]:36956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQD4L-0005ME-Ch for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Aug 2022 15:26:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQCIJ-0005Pu-3N for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 14:37:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51972) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQCII-0003M1-P8 for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 14:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oQCII-0002cn-DZ for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 14:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Aug 2022 18:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57266 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57266-submit@debbugs.gnu.org id=B57266.166119336510026 (code B ref 57266); Mon, 22 Aug 2022 18:37:02 +0000 Original-Received: (at 57266) by debbugs.gnu.org; 22 Aug 2022 18:36:05 +0000 Original-Received: from localhost ([127.0.0.1]:41721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQCHN-0002bd-92 for submit@debbugs.gnu.org; Mon, 22 Aug 2022 14:36:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQCHJ-0002b7-NI for 57266@debbugs.gnu.org; Mon, 22 Aug 2022 14:36:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQCHD-0003EX-Eh; Mon, 22 Aug 2022 14:35:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=c9tURtlKx8MebDtYtIiNrnjk7yQDzbatr8uvurbl2wk=; b=e5z2beloOw+p MAYUZ3hQm126TVC+c17DL98yYrUbhtHvRYUAyTWzkSvWLwAoSF2fQGTDE89i9ie3TJXRfmOqSQr6k MoEU0PKlXt+KOH/QRPRwZpJtA002bpBRt8ev7Tsh4SVKaPJypANoEyCUvYPA8I7mKkWszTkGRNyGp VhVs3hos7vOxKntX2P2QKA7jCtk5WlyrnOzzfrXgsCBCajDEDTzh8XIFejk8TzTsDsNl2W0Gw1xP9 vb1B/8nkSCWz3fUQzKRAvuQPamOBHmokCs8MXp8LrOxyk3nKEqkL/tJxbSVYfkR/YVKLuk+SI/2VL TD2NyJ4tNddNG3BjHCJlcg==; Original-Received: from [87.69.77.57] (port=1728 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQCH7-0007Dj-Ov; Mon, 22 Aug 2022 14:35:54 -0400 In-Reply-To: (message from Stefan Monnier on Mon, 22 Aug 2022 14:02:44 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240465 Archived-At: > From: Stefan Monnier > Cc: 57266@debbugs.gnu.org > Date: Mon, 22 Aug 2022 14:02:44 -0400 > > > Which is why I'm perfectly OK with documenting what the code does. > > But I'm not. Because I don't really know what the code does. > The doc I wrote documents the design I came up with based on my > understanding of what the code does. IME, our "understanding" what the display code does is frequently flawed, and we discover that too late. > I went through the trouble of figuring out a design of how things > *should* work, document it, and adjust the code to match the design. > So I'm not interested in pushing some half-assed version of it that > documents a design that doesn't match the reality, nor pushing partial > fixes/workarounds (for borderline cases that noone ever bumped into > anyway) while keeping the mess of unexplained hacks. I agree that if we were writing the display engine today, we'd do many things differently and more cleanly. But we are not at that place, and the (marginal at best) advantages of having the code match your understanding do not justify the risk of subtle and hard-to-debug display glitches. > > Please! I hope my requests mean something, given that I'm the only > > one who works on bugs in these areas, and probably will keep doing > > that for the observable future. > > Indeed, my proposed patch is not a bug fix. > It's a code-maintenance patch. It's meant to improve the code, not > the behavior. Sorry, I had (and still have from time to time) enough fallout from similar experiments of yours around Emacs 25, which also aimed at improving the code (by removing various reasons to perform more thorough redisplay). I'd rather not repeat that.