From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58464: 28.1; browse-url-emacs doesn't work for local files on Windows Date: Thu, 13 Oct 2022 22:15:45 +0300 Message-ID: <83a65za61q.fsf@gnu.org> References: <82k055fsos.fsf@gmail.com> <87y1tlcn7u.fsf@gnus.org> <83czaxchgp.fsf@gnu.org> <87mta1b2p9.fsf@gnus.org> <83sfjtazln.fsf@gnu.org> <87edvdays6.fsf@gnus.org> <83leplavfs.fsf@gnu.org> <871qrdavc6.fsf@gnus.org> <83ilkpauuz.fsf@gnu.org> <87r0zc88fn.fsf@gnus.org> <83wn949fui.fsf@gnu.org> <8735bs7yg0.fsf@gnus.org> <6cc4566c-00f8-8fa1-4dcd-411539972f87@cs.ucla.edu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9645"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pquessev@gmail.com, larsi@gnus.org, 58464@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 13 21:20:57 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oj3lI-0002Ks-F2 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 21:20:56 +0200 Original-Received: from localhost ([::1]:60454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oj3lH-0001bV-6t for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 15:20:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oj3hW-0006Ko-GT for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 15:17:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35910) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oj3hW-0006xl-7o for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 15:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oj3hW-0002kT-0e for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 15:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Oct 2022 19:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58464 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 58464-submit@debbugs.gnu.org id=B58464.166568857410479 (code B ref 58464); Thu, 13 Oct 2022 19:17:01 +0000 Original-Received: (at 58464) by debbugs.gnu.org; 13 Oct 2022 19:16:14 +0000 Original-Received: from localhost ([127.0.0.1]:34985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj3gk-0002iv-7b for submit@debbugs.gnu.org; Thu, 13 Oct 2022 15:16:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj3gh-0002iS-Lc for 58464@debbugs.gnu.org; Thu, 13 Oct 2022 15:16:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43914) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oj3gb-0006o9-LK; Thu, 13 Oct 2022 15:16:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JE1FGa1mD1A5zeajlik4FJfYC5Bz8VQXWylhvl0tD/A=; b=d0bE2kpAAIvO eQbqklS/jOm6a6vZLtyzz7PsqaNd2mDkvM2ulJmT6kdU0qrCHKsdo5LwDl2nFnONFT/MpTtNG0KS9 FViXrQXSuhRClQZM46tMM0MIBUGlp8HNdyDBZTYJCLYaMxDPwOA8FZo+OsdzsV6CvuXZDx9TKoARb kiCwViNvYmiDLlpBp2Yn8611LCiU7VPYpXMAPkZCk/jW38+8IWSUsgVP/gQOD6MLjj1Lv80N0UOeS a8yqCpDU8MB33N4ZI/+styW9chovCyzL6zaVjz8TdNu7C0XFzt7rXlwm82FsTRmdN7x34uVjtOfBz mfPXzgcCR9wFlx3MCpJn6Q==; Original-Received: from [87.69.77.57] (port=3073 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oj3gR-0001Wb-C4; Thu, 13 Oct 2022 15:16:05 -0400 In-Reply-To: <6cc4566c-00f8-8fa1-4dcd-411539972f87@cs.ucla.edu> (message from Paul Eggert on Thu, 13 Oct 2022 09:40:54 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245341 Archived-At: > Date: Thu, 13 Oct 2022 09:40:54 -0700 > Cc: pquessev@gmail.com, 58464@debbugs.gnu.org > From: Paul Eggert > > >> - if (NILP (handler) && !NILP (visit) && current_buffer->modtime.tv_nsec < 0) > >> + if (save_errno != 0) > >> > >> might cause us signal an error when VISIT is nil, something that > >> didn't happen before. > > We should be OK there. If VISIT is nil, SAVE_ERRNO must be zero. > > >> (I also am not sure it is 100% reliable to rely on save_errno being > >> non-zero whenever we encounter an error, especially in the > >> file-handlers case.) > > Should be OK here too. In the file-handlers case, SAVE_ERRNO is zero. Famous last words.