From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54704: [PATCH] 29.0.50; Broken code assistance for Scheme libraries Date: Mon, 26 Dec 2022 14:49:33 +0200 Message-ID: <83a63a2uua.fsf@gnu.org> References: <83a63d5765.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3554"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54704@debbugs.gnu.org To: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 26 13:50:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p9mvp-0000hD-EP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Dec 2022 13:50:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p9mvc-0000qY-Gg; Mon, 26 Dec 2022 07:50:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9mva-0000qL-Kt for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2022 07:50:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p9mva-0007XX-60 for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2022 07:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p9mvZ-0001IZ-NC for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2022 07:50:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Dec 2022 12:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54704 X-GNU-PR-Package: emacs Original-Received: via spool by 54704-submit@debbugs.gnu.org id=B54704.16720589794958 (code B ref 54704); Mon, 26 Dec 2022 12:50:01 +0000 Original-Received: (at 54704) by debbugs.gnu.org; 26 Dec 2022 12:49:39 +0000 Original-Received: from localhost ([127.0.0.1]:50911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9mvC-0001Hu-Ov for submit@debbugs.gnu.org; Mon, 26 Dec 2022 07:49:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9mv9-0001Hf-SE for 54704@debbugs.gnu.org; Mon, 26 Dec 2022 07:49:37 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9mv4-0007US-B3; Mon, 26 Dec 2022 07:49:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=b3AtYSiZV3hePj1QVBwKSDYCk0q7ELUAzpxFKMWq1/c=; b=Np3UmWU4mx+LqFpwaDLb 7csohXOykcEFlTLe4SIw4cK5fqLaZdbM2TOSl8fvYxlDijS5HwpY2nm5Sr+wgYGmCEP/LcPDW1ltB 3Y9lggB1J5gAd++gVL3chMIwac3iksPQF0/1Db2y0vEDdCGZRT8QTTNd0Y829EAb7WjoBztXabX41 ERr+YCveuun4PgPfQEdsqFmFmPy4kGGRDPlK0StxP+sDLfUXbf1OvOthehy/ljZXHTteFu//f62Bg cve1NGY790D73aj9Rt4y2bXATU+4f3hgKodSGhH8QDRSdmbuhCnwYtJSwHBPRiweZaaOvsx6A1XXP ++wgyfxYCdhP5Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9mv3-0004Ji-Hx; Mon, 26 Dec 2022 07:49:29 -0500 In-Reply-To: (message from Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= on Sat, 24 Dec 2022 23:32:21 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251900 Archived-At: > From: Rudolf Adamkovič > Cc: 54704@debbugs.gnu.org > Date: Sat, 24 Dec 2022 23:32:21 +0100 > > Eli Zaretskii writes: > > >> Please see the attached patch that makes Emacs recognize R6RS/R7RS > >> library files, as well as, makes Emacs recognize their members. > > > > Thanks. > > Thank you for your review! > > > The "+++" mark means that the manuals have been updated with this > > information. I don't think this is the case, and we don't have any > > manuals for the Scheme mode, right? So this should be "---" instead. > > Fixed. > > >> +*** Auto-detection of Scheme library files > > > > Heading lines in NEWS should end with a period. > > Fixed. > > >> +Emacs now automatically enables the Scheme mode for R6RS library > >> +sources ('.sls') and R7RS library definitions ('.sld'). > > > > "source files" and "library definition files", right? > > Nope. Historically, Scheme has two *standard* library definitions, > incompatible with each other, due to a bit "screwed up" transition from > R5RS to R6RS and then R7RS. While not mandated by the standards R6RS > and R7RS standards, in the wild, these come as: > > - Scheme Library Source ('.sls') for R6RS > - Scheme Library Definition ('.sld) for R7RS > > However! I see how this can confuse the user, so I reworded both items > in the NEWS file. Importantly, I capitalized the names and put them > right next to their extensions, to tie it all together. Better? > > >> ++++ > >> +*** Imenu members for R6RS and R7RS library members > > > > Same comments here. > > Fixed. Thanks. I'd like to install this on the emacs-29 branch, so could you please rebase the patch on top of emacs-29 and resubmit?