From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60565: [PATCH] src/pgtkfns.c (parse_resource_key): Use recursive schema lookup Date: Sat, 07 Jan 2023 11:12:29 +0200 Message-ID: <83a62uu2rm.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="552"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60565@debbugs.gnu.org To: Tad Fisher , Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 07 10:13:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pE5GI-000AYX-TM for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Jan 2023 10:13:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pE5GB-0006RJ-Uf; Sat, 07 Jan 2023 04:13:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE5GA-0006Qu-TJ for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 04:13:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pE5GA-0000QL-CZ for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 04:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pE5GA-0000sJ-7G for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 04:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jan 2023 09:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60565 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60565-submit@debbugs.gnu.org id=B60565.16730827393293 (code B ref 60565); Sat, 07 Jan 2023 09:13:02 +0000 Original-Received: (at 60565) by debbugs.gnu.org; 7 Jan 2023 09:12:19 +0000 Original-Received: from localhost ([127.0.0.1]:56427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pE5FT-0000r3-Ag for submit@debbugs.gnu.org; Sat, 07 Jan 2023 04:12:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pE5FR-0000qp-Ux for 60565@debbugs.gnu.org; Sat, 07 Jan 2023 04:12:18 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE5FM-0000Lz-OT; Sat, 07 Jan 2023 04:12:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vM4W3Cro0rkzB+I7W+2w/QMtCb6SkrgT+SCyF2LOoUM=; b=abm0aOQyPmU5 83BBKgFAzPCb+ISbmscYLNqxBQ0EH3WCHxedXOJj0p7AyCdfkUVfKVfaL96zCBsvKu6mz54KOwpRR JysqvwKTRdZ3PjkClJEiaSvGzx0BSPMt2UD1g2EGWgslsaQkBteIW2Oolvz3PXbPFAarAesJuz4Mr Xwrxk3wzKjJzTl78RruZfdp8BW2Mwv6xTp0evIbgfG07Bo7DZvGEpBDWIZOcEfUKijphIqC7a8dut NW20SgObksJEyxqMDTZAPpIXgQO6A2+dJlFkQOoBXGgi0hS0g34CbLq4VdFTh8/TUbjEN0hyr2fAC Meyfbfjt/b60qKVIKQhWWw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE5FJ-0004Y3-59; Sat, 07 Jan 2023 04:12:12 -0500 In-Reply-To: (message from Tad Fisher on Thu, 5 Jan 2023 01:58:47 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252772 Archived-At: > From: Tad Fisher > Date: Thu, 5 Jan 2023 01:58:47 +0000 > > > From 8e2cf80593dd78030929f96f0f1a3e1a325428a4 Mon Sep 17 00:00:00 2001 > From: Tad Fisher > Date: Wed, 4 Jan 2023 13:40:17 -0800 > Subject: [PATCH] ; * src/pgtkfns.c (parse_resource_key): Use recursive schema lookup > > XDG_DATA_DIRS may consist of multiple directories, and > g_settings_schema_source_get_default composes these into a recursive > schema source. One must pass TRUE to g_settings_schema_source_lookup, > otherwise only the first directory in XDG_DATA_DIRS is searched. > > It follows that in the case that the directory containing the compiled > GSettings schema for Emacs is not the first in XDG_DATA_DIRS, > parse_resource_key will not accept any resource key, which causes > pgtk_get_defaults_value and pgtk_set_defaults_value to fail. > > This impacts systems that compose multiple GSettings schema sources > via XDG_DATA_DIRS, such Flatpak and NixOS. > > Supporting GIO documentation for g_settings_schema_source_get_default: > > > The returned source may actually consist of multiple schema sources > > from different directories, depending on which directories were given > > in `XDG_DATA_DIRS` and `GSETTINGS_SCHEMA_DIR`. For this reason, all > > lookups performed against the default source should probably be done > > recursively. Thanks. Po Lu, any comments?